Repository: asterixdb Updated Branches: refs/heads/master f99da85d7 -> bebe109bf
[NO ISSUE][RT] Remove Invalid Clear Queued Jobs API - user model changes: no - storage format changes: no - interface changes: yes - Remove clearJobQueue from IJobManager. Details: - The current clearJobQueue API in IJobManager does not follow the typical job lifecycle. i.e. job lifecycle listener are not notified that the jobs were canceled. Since the API is not used, this change removes it to avoid any future invalid usage. Change-Id: I1bff81fe9378f9bbc9dfb04a6a9826ee052f0965 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2237 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Till Westmann <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/bebe109b Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/bebe109b Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/bebe109b Branch: refs/heads/master Commit: bebe109bf8d04dfee504026178ed2ac3b822c8c4 Parents: f99da85 Author: Murtadha Hubail <[email protected]> Authored: Tue Dec 19 08:58:40 2017 +0300 Committer: Murtadha Hubail <[email protected]> Committed: Tue Dec 19 16:12:18 2017 -0800 ---------------------------------------------------------------------- .../java/org/apache/hyracks/control/cc/job/IJobManager.java | 5 ----- .../main/java/org/apache/hyracks/control/cc/job/JobManager.java | 5 ----- 2 files changed, 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/asterixdb/blob/bebe109b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java ---------------------------------------------------------------------- diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java index cda3037..a9ddee3 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java @@ -125,9 +125,4 @@ public interface IJobManager { * @return the maximum number of jobs to queue before rejecting new jobs */ int getJobQueueCapacity(); - - /** - * Clears all queued jobs - */ - void clearJobQueue(); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/bebe109b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java ---------------------------------------------------------------------- diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java index ffb72c9..b728e73 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java @@ -290,11 +290,6 @@ public class JobManager implements IJobManager { return ccs.getCCConfig().getJobQueueCapacity(); } - @Override - public void clearJobQueue() { - jobQueue.clear(); - } - private void pickJobsToRun() throws HyracksException { List<JobRun> selectedRuns = jobQueue.pull(); for (JobRun run : selectedRuns) {
