http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java index d363f3d..963f0ca 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java @@ -43,16 +43,14 @@ public class StorageProperties extends AbstractProperties { STORAGE_MEMORYCOMPONENT_GLOBALBUDGET(LONG_BYTE_UNIT, Runtime.getRuntime().maxMemory() / 4), STORAGE_MEMORYCOMPONENT_PAGESIZE(INTEGER_BYTE_UNIT, StorageUtil.getIntSizeInBytes(128, KILOBYTE)), STORAGE_MEMORYCOMPONENT_NUMPAGES(INTEGER, (Function<IApplicationConfig, Integer>) accessor -> - // By default, uses 1/16 of the STORAGE_MEMORYCOMPONENT_GLOBALBUDGET for the write buffer - // budget for a dataset, including data and indexes. - (int) (accessor.getLong(STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) / - (16 * accessor.getInt(STORAGE_MEMORYCOMPONENT_PAGESIZE)))), + // By default, uses 1/16 of the STORAGE_MEMORYCOMPONENT_GLOBALBUDGET for the write buffer + // budget for a dataset, including data and indexes. + (int) (accessor.getLong(STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) / (16 * accessor.getInt(STORAGE_MEMORYCOMPONENT_PAGESIZE)))), STORAGE_MEMORYCOMPONENT_NUMCOMPONENTS(INTEGER, 2), STORAGE_METADATA_MEMORYCOMPONENT_NUMPAGES(INTEGER, (Function<IApplicationConfig, Integer>) accessor -> - // By default, uses the min of 1/64 of the STORAGE_MEMORYCOMPONENT_GLOBALBUDGET and 256 pages - // for the write buffer budget for a metadata dataset, including data and indexes. - Math.min((int) (accessor.getLong(STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) - / (64 * accessor.getInt(STORAGE_MEMORYCOMPONENT_PAGESIZE))), 256)), + // By default, uses the min of 1/64 of the STORAGE_MEMORYCOMPONENT_GLOBALBUDGET and 256 pages + // for the write buffer budget for a metadata dataset, including data and indexes. + Math.min((int) (accessor.getLong(STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) / (64 * accessor.getInt(STORAGE_MEMORYCOMPONENT_PAGESIZE))), 256)), STORAGE_LSM_BLOOMFILTER_FALSEPOSITIVERATE(DOUBLE, 0.01d); private final IOptionType interpreter; @@ -79,20 +77,20 @@ public class StorageProperties extends AbstractProperties { case STORAGE_BUFFERCACHE_PAGESIZE: return "The page size in bytes for pages in the buffer cache"; case STORAGE_BUFFERCACHE_SIZE: - return "The size of memory allocated to the disk buffer cache. The value should be a multiple" + - " of the buffer cache page size."; + return "The size of memory allocated to the disk buffer cache. The value should be a multiple" + + " of the buffer cache page size."; case STORAGE_BUFFERCACHE_MAXOPENFILES: return "The maximum number of open files in the buffer cache"; case STORAGE_MEMORYCOMPONENT_GLOBALBUDGET: - return "The size of memory allocated to the memory components. The value should be a multiple " + - "of the memory component page size"; + return "The size of memory allocated to the memory components. The value should be a multiple " + + "of the memory component page size"; case STORAGE_MEMORYCOMPONENT_PAGESIZE: return "The page size in bytes for pages allocated to memory components"; case STORAGE_MEMORYCOMPONENT_NUMPAGES: - return "The number of pages to allocate for a memory component. This budget is shared by all " + - "the memory components of the primary index and all its secondary indexes across all I/O " + - "devices on a node. Note: in-memory components usually has fill factor of 75% since " + - "the pages are 75% full and the remaining 25% is un-utilized"; + return "The number of pages to allocate for a memory component. This budget is shared by all " + + "the memory components of the primary index and all its secondary indexes across all I/O " + + "devices on a node. Note: in-memory components usually has fill factor of 75% since " + + "the pages are 75% full and the remaining 25% is un-utilized"; case STORAGE_MEMORYCOMPONENT_NUMCOMPONENTS: return "The number of memory components to be used per lsm index"; case STORAGE_METADATA_MEMORYCOMPONENT_NUMPAGES: @@ -114,16 +112,15 @@ public class StorageProperties extends AbstractProperties { return defaultValue; } - @Override public String usageDefaultOverride(IApplicationConfig accessor, Function<IOption, String> optionPrinter) { switch (this) { case STORAGE_MEMORYCOMPONENT_NUMPAGES: - return "1/16th of the " + optionPrinter.apply(Option.STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) + - " value"; + return "1/16th of the " + optionPrinter.apply(Option.STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) + + " value"; case STORAGE_METADATA_MEMORYCOMPONENT_NUMPAGES: - return "1/64th of the " + optionPrinter.apply(Option.STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) + - " value or 256, whichever is larger"; + return "1/64th of the " + optionPrinter.apply(Option.STORAGE_MEMORYCOMPONENT_GLOBALBUDGET) + + " value or 256, whichever is larger"; default: return null; }
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java index b809b4d..c15f8a7 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java @@ -36,26 +36,39 @@ public class TransactionProperties extends AbstractProperties { public enum Option implements IOption { TXN_LOG_BUFFER_NUMPAGES(INTEGER, 8, "The number of pages in the transaction log tail"), - TXN_LOG_BUFFER_PAGESIZE(INTEGER_BYTE_UNIT, StorageUtil.getIntSizeInBytes(128, KILOBYTE), + TXN_LOG_BUFFER_PAGESIZE( + INTEGER_BYTE_UNIT, + StorageUtil.getIntSizeInBytes(128, KILOBYTE), "The page size (in bytes) for transaction log buffer"), - TXN_LOG_PARTITIONSIZE(LONG_BYTE_UNIT, StorageUtil.getLongSizeInBytes(256L, MEGABYTE), + TXN_LOG_PARTITIONSIZE( + LONG_BYTE_UNIT, + StorageUtil.getLongSizeInBytes(256L, MEGABYTE), "The maximum size (in bytes) of each transaction log file"), - TXN_LOG_CHECKPOINT_LSNTHRESHOLD(INTEGER_BYTE_UNIT, StorageUtil.getIntSizeInBytes(64, MEGABYTE), - "The checkpoint threshold (in terms of LSNs (log sequence numbers) that have been written to the " + - "transaction log, i.e., the length of the transaction log) for transaction logs"), - TXN_LOG_CHECKPOINT_POLLFREQUENCY(INTEGER, 120, - "The frequency (in seconds) the checkpoint thread should check to see if a checkpoint should be written" - ), + TXN_LOG_CHECKPOINT_LSNTHRESHOLD( + INTEGER_BYTE_UNIT, + StorageUtil.getIntSizeInBytes(64, MEGABYTE), + "The checkpoint threshold (in terms of LSNs (log sequence numbers) that have been written to the " + + "transaction log, i.e., the length of the transaction log) for transaction logs"), + TXN_LOG_CHECKPOINT_POLLFREQUENCY( + INTEGER, + 120, + "The frequency (in seconds) the checkpoint thread should check to see if a checkpoint should be written"), TXN_LOG_CHECKPOINT_HISTORY(INTEGER, 0, "The number of checkpoints to keep in the transaction log"), - TXN_LOCK_ESCALATIONTHRESHOLD(INTEGER, 1000, + TXN_LOCK_ESCALATIONTHRESHOLD( + INTEGER, + 1000, "The maximum number of entity locks to obtain before upgrading to a dataset lock"), - TXN_LOCK_SHRINKTIMER(INTEGER, 5000, + TXN_LOCK_SHRINKTIMER( + INTEGER, + 5000, "The time (in milliseconds) where under utilization of resources will trigger a shrink phase"), TXN_LOCK_TIMEOUT_WAITTHRESHOLD(INTEGER, 60000, "Time out (in milliseconds) of waiting for a lock"), TXN_LOCK_TIMEOUT_SWEEPTHRESHOLD(INTEGER, 10000, "Interval (in milliseconds) for checking lock timeout"), TXN_COMMITPROFILER_ENABLED(BOOLEAN, false, "Enable output of commit profiler logs"), TXN_COMMITPROFILER_REPORTINTERVAL(INTEGER, 5, "Interval (in seconds) to report commit profiler logs"), - TXN_JOB_RECOVERY_MEMORYSIZE(LONG_BYTE_UNIT, StorageUtil.getLongSizeInBytes(64L, MEGABYTE), + TXN_JOB_RECOVERY_MEMORYSIZE( + LONG_BYTE_UNIT, + StorageUtil.getLongSizeInBytes(64L, MEGABYTE), "The memory budget (in bytes) used for recovery"); private final IOptionType type; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java index e839d8c..34d0774 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java @@ -109,9 +109,9 @@ public class DatasetMemoryManager implements IDatasetMemoryManager { @Override public int getNumPages(int datasetId) { - return MetadataIndexImmutableProperties.isMetadataDataset(datasetId) ? - storageProperties.getMetadataMemoryComponentNumPages() : - storageProperties.getMemoryComponentNumPages(); + return MetadataIndexImmutableProperties.isMetadataDataset(datasetId) + ? storageProperties.getMetadataMemoryComponentNumPages() + : storageProperties.getMemoryComponentNumPages(); } private long getTotalSize(int datasetId) { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/functions/FunctionSignature.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/functions/FunctionSignature.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/functions/FunctionSignature.java index d4b4215..d7b054d 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/functions/FunctionSignature.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/functions/FunctionSignature.java @@ -44,9 +44,10 @@ public class FunctionSignature implements Serializable { return false; } else { FunctionSignature f = ((FunctionSignature) o); - return ((namespace != null && namespace.equals(f.getNamespace()) || (namespace == null && f.getNamespace() == null))) - && name.equals(f.getName()) - && (arity == f.getArity() || arity == FunctionIdentifier.VARARGS || f.getArity() == FunctionIdentifier.VARARGS); + return ((namespace != null && namespace.equals(f.getNamespace()) + || (namespace == null && f.getNamespace() == null))) && name.equals(f.getName()) + && (arity == f.getArity() || arity == FunctionIdentifier.VARARGS + || f.getArity() == FunctionIdentifier.VARARGS); } } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java index c625988..bacebf1 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java @@ -125,9 +125,9 @@ public abstract class AbstractLSMIOOperationCallback implements ILSMIOOperationC if (oldComponents == null) { throw new IllegalStateException("Merge must have old components"); } - LongPointable markerLsn = LongPointable.FACTORY.createPointable(ComponentUtils - .getLong(oldComponents.get(0).getMetadata(), ComponentUtils.MARKER_LSN_KEY, - ComponentUtils.NOT_FOUND)); + LongPointable markerLsn = + LongPointable.FACTORY.createPointable(ComponentUtils.getLong(oldComponents.get(0).getMetadata(), + ComponentUtils.MARKER_LSN_KEY, ComponentUtils.NOT_FOUND)); newComponent.getMetadata().put(ComponentUtils.MARKER_LSN_KEY, markerLsn); } else if (opType == LSMIOOperationType.FLUSH) { // advance memory component indexes @@ -182,8 +182,8 @@ public abstract class AbstractLSMIOOperationCallback implements ILSMIOOperationC if (mergedComponents == null || mergedComponents.isEmpty()) { return null; } - return LSMComponentIdUtils - .union(mergedComponents.get(0).getId(), mergedComponents.get(mergedComponents.size() - 1).getId()); + return LSMComponentIdUtils.union(mergedComponents.get(0).getId(), + mergedComponents.get(mergedComponents.size() - 1).getId()); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/memory/ConcurrentFramePool.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/memory/ConcurrentFramePool.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/memory/ConcurrentFramePool.java index d522aa5..b7d34f2 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/memory/ConcurrentFramePool.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/memory/ConcurrentFramePool.java @@ -33,10 +33,10 @@ import org.apache.logging.log4j.Logger; public class ConcurrentFramePool { private static final boolean DEBUG = false; - private static final String ERROR_INVALID_FRAME_SIZE = "The size should be an integral " - + "multiple of the default frame size"; - private static final String ERROR_LARGER_THAN_BUDGET_REQUEST = "The requested frame size" - + " must not be greater than the allocated budget"; + private static final String ERROR_INVALID_FRAME_SIZE = + "The size should be an integral " + "multiple of the default frame size"; + private static final String ERROR_LARGER_THAN_BUDGET_REQUEST = + "The requested frame size" + " must not be greater than the allocated budget"; private static final Logger LOGGER = LogManager.getLogger(); private final String nodeId; private final int budget; @@ -234,8 +234,8 @@ public class ConcurrentFramePool { try { frameAction.call(freeBuffer); } catch (Exception e) { - LOGGER.log(Level.ERROR, - "Error while attempting to answer a subscription. Buffer will be reclaimed", e); + LOGGER.log(Level.ERROR, "Error while attempting to answer a subscription. Buffer will be reclaimed", + e); // TODO(amoudi): Add test cases and get rid of recursion if (handedOut == handedOutBeforeCall) { release(freeBuffer); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java index 6ec2d7e..6bd58a9 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java @@ -45,8 +45,7 @@ public interface INCMessageBroker extends IMessageBroker { * @param message * @throws Exception */ - public void sendMessageToNC(String nodeId, INcAddressedMessage message) - throws Exception; + public void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception; /** * Queue a message to this {@link INCMessageBroker} for processing http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/PrintUtil.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/PrintUtil.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/PrintUtil.java index 8c0e4ff..d02ef7c 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/PrintUtil.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/PrintUtil.java @@ -38,7 +38,7 @@ public class PrintUtil { sb.append(entry.getKey()); sb.append('='); sb.append(Arrays.toString(entry.getValue())); - if (! iter.hasNext()) { + if (!iter.hasNext()) { break; } sb.append(',').append(' '); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java index 7b9a9a2..6b13468 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java @@ -77,9 +77,8 @@ public class StoragePathUtil { } public static int getPartitionNumFromRelativePath(String relativePath) { - int startIdx = - relativePath.indexOf(StorageConstants.PARTITION_DIR_PREFIX) + StorageConstants.PARTITION_DIR_PREFIX - .length(); + int startIdx = relativePath.indexOf(StorageConstants.PARTITION_DIR_PREFIX) + + StorageConstants.PARTITION_DIR_PREFIX.length(); String partition = relativePath.substring(startIdx, relativePath.indexOf(File.separatorChar, startIdx)); return Integer.parseInt(partition); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/base/RetainLogsRule.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/base/RetainLogsRule.java b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/base/RetainLogsRule.java index 2077ad5..1fe7dc2 100644 --- a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/base/RetainLogsRule.java +++ b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/base/RetainLogsRule.java @@ -49,12 +49,12 @@ public class RetainLogsRule extends TestWatcher { @Override protected void failed(Throwable e, Description description) { - File reportDir = new File(destDir, description.getTestClass().getSimpleName() + "." + description.getMethodName()); + File reportDir = + new File(destDir, description.getTestClass().getSimpleName() + "." + description.getMethodName()); reportDir.mkdirs(); try { AsterixTestHelper.deepSelectiveCopy(baseDir, reportDir, - pathname -> pathname.getName().endsWith("log") && - pathname.lastModified() > startTime); + pathname -> pathname.getName().endsWith("log") && pathname.lastModified() > startTime); } catch (Exception e1) { e1.printStackTrace(); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/memory/ConcurrentFramePoolUnitTest.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/memory/ConcurrentFramePoolUnitTest.java b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/memory/ConcurrentFramePoolUnitTest.java index 9be5837..0243a63 100644 --- a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/memory/ConcurrentFramePoolUnitTest.java +++ b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/memory/ConcurrentFramePoolUnitTest.java @@ -60,8 +60,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { public void testMemoryManager() { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); int i = 0; while (fmm.get() != null) { i++; @@ -75,8 +75,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); FixedSizeAllocator[] runners = new FixedSizeAllocator[NUM_THREADS]; Thread[] threads = new Thread[NUM_THREADS]; Arrays.parallelSetAll(runners, (int i) -> new FixedSizeAllocator(fmm)); @@ -106,8 +106,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); Random random = new Random(); int i = 0; int req; @@ -141,8 +141,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); VarSizeAllocator[] runners = new VarSizeAllocator[NUM_THREADS]; Thread[] threads = new Thread[NUM_THREADS]; @@ -180,8 +180,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { public void testAcquireReleaseMemoryManager() throws HyracksDataException { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); Random random = new Random(); ArrayDeque<ByteBuffer> stack = new ArrayDeque<>(); while (true) { @@ -213,8 +213,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); FixedSizeGoodAllocator[] runners = new FixedSizeGoodAllocator[NUM_THREADS]; Thread[] threads = new Thread[NUM_THREADS]; Arrays.parallelSetAll(runners, (int i) -> new FixedSizeGoodAllocator(fmm)); @@ -244,8 +244,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); Random random = new Random(); ArrayDeque<ByteBuffer> stack = new ArrayDeque<>(); int i = 0; @@ -297,8 +297,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); VarSizeGoodAllocator[] runners = new VarSizeGoodAllocator[NUM_THREADS]; Thread[] threads = new Thread[NUM_THREADS]; Arrays.parallelSetAll(runners, (int i) -> new VarSizeGoodAllocator(fmm)); @@ -333,8 +333,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); int i = 0; ByteBuffer buffer = ByteBuffer.allocate(DEFAULT_FRAME_SIZE); LinkedBlockingDeque<ByteBuffer> buffers = new LinkedBlockingDeque<>(); @@ -399,8 +399,8 @@ public class ConcurrentFramePoolUnitTest extends TestCase { try { ActiveProperties afp = Mockito.mock(ActiveProperties.class); Mockito.when(afp.getMemoryComponentGlobalBudget()).thenReturn(FEED_MEM_BUDGET); - ConcurrentFramePool fmm = new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), - DEFAULT_FRAME_SIZE); + ConcurrentFramePool fmm = + new ConcurrentFramePool("TestNode", afp.getMemoryComponentGlobalBudget(), DEFAULT_FRAME_SIZE); int i = 0; ByteBuffer buffer = ByteBuffer.allocate(DEFAULT_FRAME_SIZE); LinkedBlockingDeque<ByteBuffer> buffers = new LinkedBlockingDeque<>(); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java index 57e79c3..2db17e2 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java @@ -33,7 +33,7 @@ public class ChangeFeedDataFlowController<T> extends FeedRecordDataFlowControlle public ChangeFeedDataFlowController(final IHyracksTaskContext ctx, final FeedTupleForwarder tupleForwarder, final FeedLogManager feedLogManager, final int numOfOutputFields, final IRecordWithPKDataParser<T> dataParser, final IRecordReader<T> recordReader) - throws HyracksDataException { + throws HyracksDataException { super(ctx, tupleForwarder, feedLogManager, numOfOutputFields, dataParser, recordReader); this.dataParser = dataParser; } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java index 22fa8be..4447b28 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java @@ -31,7 +31,7 @@ public class ChangeFeedWithMetaDataFlowController<T> extends FeedWithMetaDataFlo public ChangeFeedWithMetaDataFlowController(final IHyracksTaskContext ctx, final FeedTupleForwarder tupleForwarder, final FeedLogManager feedLogManager, final int numOfOutputFields, final IRecordWithMetadataParser<T> dataParser, final IRecordReader<T> recordReader) - throws HyracksDataException { + throws HyracksDataException { super(ctx, tupleForwarder, feedLogManager, numOfOutputFields, dataParser, recordReader); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java index 8026efe..3b9391e 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java @@ -282,7 +282,7 @@ public class FeedRecordDataFlowController<T> extends AbstractFeedDataFlowControl @Override public String getStats() { - return "{\"" + INCOMING_RECORDS_COUNT_FIELD_NAME + "\": " + incomingRecordsCount + ", \"" + - FAILED_AT_PARSER_RECORDS_COUNT_FIELD_NAME + "\": " + failedRecordsCount + "}"; + return "{\"" + INCOMING_RECORDS_COUNT_FIELD_NAME + "\": " + incomingRecordsCount + ", \"" + + FAILED_AT_PARSER_RECORDS_COUNT_FIELD_NAME + "\": " + failedRecordsCount + "}"; } } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java index 82251b6..0f9572d 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/RecordDataFlowController.java @@ -34,8 +34,7 @@ public class RecordDataFlowController<T> extends AbstractDataFlowController { protected final int numOfTupleFields; public RecordDataFlowController(IHyracksTaskContext ctx, ITupleForwarder tupleForwarder, - IRecordDataParser<T> dataParser, IRecordReader<? extends T> recordReader, - int numOfTupleFields) { + IRecordDataParser<T> dataParser, IRecordReader<? extends T> recordReader, int numOfTupleFields) { super(ctx, tupleForwarder); this.dataParser = dataParser; this.recordReader = recordReader; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java index dd713e6..aeeb04d 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java @@ -57,7 +57,7 @@ public final class LookupAdapter<T> implements IFrameWriter { public LookupAdapter(IRecordDataParser<T> dataParser, ILookupRecordReader<? extends T> recordReader, RecordDescriptor inRecDesc, RecordIdReader ridReader, boolean propagateInput, boolean retainNull, IMissingWriterFactory iNullWriterFactory, IHyracksTaskContext ctx, IFrameWriter writer) - throws HyracksDataException { + throws HyracksDataException { this.dataParser = dataParser; this.recordReader = recordReader; this.propagateInput = propagateInput; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java index df5a3c4..b89c10b 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java @@ -77,11 +77,9 @@ public class FeedRuntimeInputHandler extends AbstractUnaryInputUnaryOutputOperat IFrameWriter writer, FeedPolicyAccessor fpa, FrameTupleAccessor fta, ConcurrentFramePool framePool) throws HyracksDataException { this.writer = writer; - this.spiller = fpa.spillToDiskOnCongestion() ? - new FrameSpiller(ctx, - connectionId.getFeedId() + "_" + connectionId.getDatasetName() + "_" + runtimeId.getPartition(), - fpa.getMaxSpillOnDisk()) : - null; + this.spiller = fpa.spillToDiskOnCongestion() ? new FrameSpiller(ctx, + connectionId.getFeedId() + "_" + connectionId.getDatasetName() + "_" + runtimeId.getPartition(), + fpa.getMaxSpillOnDisk()) : null; this.exceptionHandler = new FeedExceptionHandler(ctx, fta); this.fpa = fpa; this.framePool = framePool; @@ -289,8 +287,8 @@ public class FeedRuntimeInputHandler extends AbstractUnaryInputUnaryOutputOperat while (spiller.usedBudget() > MAX_SPILL_USED_BEFORE_RESUME) { if (DEBUG) { LOGGER.info("in stall(frame). Spilling has been consumed. We will wait for it to be less than " - + MAX_SPILL_USED_BEFORE_RESUME + " consumed. Current consumption = " + spiller - .usedBudget()); + + MAX_SPILL_USED_BEFORE_RESUME + " consumed. Current consumption = " + + spiller.usedBudget()); } spiller.wait(); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java index 9bc3037..a0feac5 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java @@ -177,12 +177,11 @@ public class DataGenerator { : (date.getMonth() + random.nextInt(endDate.getMonth() - date.getMonth())) : random.nextInt(12) + 1; - int day = (year == endDate.getYear()) - ? month == endDate.getMonth() + int day = + (year == endDate.getYear()) ? month == endDate.getMonth() ? date.getDay() == endDate.getDay() ? endDate.getDay() : date.getDay() + random.nextInt(endDate.getDay() - date.getDay()) - : random.nextInt(28) + 1 - : random.nextInt(28) + 1; + : random.nextInt(28) + 1 : random.nextInt(28) + 1; recentDate.reset(month, day, year); return recentDate; } @@ -495,9 +494,9 @@ public class DataGenerator { public static class TweetMessage { - private static final String[] DEFAULT_FIELDS = new String[] { TweetFields.TWEETID, TweetFields.USER, - TweetFields.LATITUDE, TweetFields.LONGITUDE, TweetFields.MESSAGE_TEXT, TweetFields.CREATED_AT, - TweetFields.COUNTRY }; + private static final String[] DEFAULT_FIELDS = + new String[] { TweetFields.TWEETID, TweetFields.USER, TweetFields.LATITUDE, TweetFields.LONGITUDE, + TweetFields.MESSAGE_TEXT, TweetFields.CREATED_AT, TweetFields.COUNTRY }; private int id; private TwitterUser user; @@ -1183,14 +1182,13 @@ public class DataGenerator { "Hallam", "Delores", "Cressida", "Carlyle", "Leann", "Kelcey", "Laurence", "Ryan", "Reynold", "Mark", "Collyn", "Audie", "Sammy", "Ellery", "Sallie", "Pamelia", "Adolph", "Lydia", "Titania", "Ron", "Bridger", "Aline", "Read", "Kelleigh", "Weldon", "Irving", "Garey", "Diggory", "Evander", "Kylee", "Deidre", "Ormond", - "Laurine", "Reannon", "Arline", "Pat"}; + "Laurine", "Reannon", "Arline", "Pat" }; public static final String[] jargon = { "wireless", "signal", "network", "3G", "plan", "touch-screen", "customer-service", "reachability", "voice-command", "shortcut-menu", "customization", "platform", "speed", "voice-clarity", "voicemail-service" }; - public static final String[] vendors = { "at&t", "verizon", "t-mobile", "sprint", "motorola", "samsung", - "iphone" }; + public static final String[] vendors = { "at&t", "verizon", "t-mobile", "sprint", "motorola", "samsung", "iphone" }; public static final String[] org_list = { "Latsonity", "ganjalax", "Zuncan", "Lexitechno", "Hot-tech", "subtam", "Coneflex", "Ganjatax", "physcane", "Tranzap", "Qvohouse", "Zununoing", "jaydax", "Keytech", "goldendexon", http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/TweetGenerator.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/TweetGenerator.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/TweetGenerator.java index 17056a0..cb64604 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/TweetGenerator.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/TweetGenerator.java @@ -99,7 +99,7 @@ public class TweetGenerator { outputBuffer.limit(32 * 1024); } - public boolean generateNextBatch(int numTweets) throws IOException{ + public boolean generateNextBatch(int numTweets) throws IOException { boolean moreData = tweetIterator.hasNext(); if (!moreData) { if (outputBuffer.position() > 0) { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java index a15ec6e..a5bff74 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java @@ -42,11 +42,11 @@ public class FileOffsetIndexer implements IExternalIndexer { protected RecordReader<?, ? extends Writable> recordReader; @SuppressWarnings("unchecked") - private ISerializerDeserializer<IAObject> intSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT32); + private ISerializerDeserializer<IAObject> intSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT32); @SuppressWarnings("unchecked") - private ISerializerDeserializer<IAObject> longSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT64); + private ISerializerDeserializer<IAObject> longSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT64); @Override public void reset(IIndexingDatasource dataSource) throws HyracksDataException { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/IndexingScheduler.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/IndexingScheduler.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/IndexingScheduler.java index 353e3ef..a788a29 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/IndexingScheduler.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/IndexingScheduler.java @@ -157,10 +157,10 @@ public class IndexingScheduler { */ private void scheduleNonLocalSlots(InputSplit[] splits, final int[] workloads, String[] locations, int slotLimit, boolean[] scheduled, final HashMap<String, Integer> locationToNumOfAssignement) - throws IOException, UnknownHostException { + throws IOException, UnknownHostException { - PriorityQueue<String> scheduleCadndiates = new PriorityQueue<String>(NCs.length, - Comparator.comparing(locationToNumOfAssignement::get)); + PriorityQueue<String> scheduleCadndiates = + new PriorityQueue<String>(NCs.length, Comparator.comparing(locationToNumOfAssignement::get)); scheduleCadndiates.addAll(Arrays.asList(NCs)); /* http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordColumnarIndexer.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordColumnarIndexer.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordColumnarIndexer.java index 273901c..e6146d4 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordColumnarIndexer.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordColumnarIndexer.java @@ -45,11 +45,11 @@ public class RecordColumnarIndexer implements IExternalIndexer { protected RecordReader<?, Writable> recordReader; @SuppressWarnings("unchecked") - private ISerializerDeserializer<IAObject> intSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT32); + private ISerializerDeserializer<IAObject> intSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT32); @SuppressWarnings("unchecked") - private ISerializerDeserializer<IAObject> longSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT64); + private ISerializerDeserializer<IAObject> longSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT64); @Override public void reset(IIndexingDatasource reader) throws HyracksDataException { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordIdReader.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordIdReader.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordIdReader.java index 5de2d9d..3cca7e1 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordIdReader.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/RecordIdReader.java @@ -57,8 +57,8 @@ public class RecordIdReader { public RecordId read(int index) throws HyracksDataException { tupleStartOffset = tupleAccessor.getTupleStartOffset(index) + fieldSlotsLength; - int fileNumberStartOffset = tupleAccessor.getFieldStartOffset(index, - ridFields[IndexingConstants.FILE_NUMBER_FIELD_INDEX]); + int fileNumberStartOffset = + tupleAccessor.getFieldStartOffset(index, ridFields[IndexingConstants.FILE_NUMBER_FIELD_INDEX]); frameBuffer = tupleAccessor.getBuffer(); if (frameBuffer.get(tupleStartOffset + fileNumberStartOffset) == MISSING_BYTE) { return null; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java index ebf1d17..f9bc8b2 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java @@ -57,24 +57,24 @@ public class RecordWithMetadataAndPK<T> extends RecordWithPK<T> { // Serializers @SuppressWarnings("unchecked") - private final ISerializerDeserializer<ADouble> doubleSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.ADOUBLE); + private final ISerializerDeserializer<ADouble> doubleSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ADOUBLE); private final AMutableDouble mutableDouble = new AMutableDouble(0); @SuppressWarnings("unchecked") - private final ISerializerDeserializer<AString> stringSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.ASTRING); + private final ISerializerDeserializer<AString> stringSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ASTRING); private final AMutableString mutableString = new AMutableString(null); @SuppressWarnings("unchecked") - private final ISerializerDeserializer<AInt32> int32Serde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT32); + private final ISerializerDeserializer<AInt32> int32Serde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT32); private final AMutableInt32 mutableInt = new AMutableInt32(0); @SuppressWarnings("unchecked") - protected ISerializerDeserializer<AInt64> int64Serde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.AINT64); + protected ISerializerDeserializer<AInt64> int64Serde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT64); private final AMutableInt64 mutableLong = new AMutableInt64(0); @SuppressWarnings("unchecked") - private final ISerializerDeserializer<ABoolean> booleanSerde = SerializerDeserializerProvider.INSTANCE - .getSerializerDeserializer(BuiltinType.ABOOLEAN); + private final ISerializerDeserializer<ABoolean> booleanSerde = + SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ABOOLEAN); private final int[] keyIndicator; public RecordWithMetadataAndPK(final IRawRecord<T> record, final IAType[] metaTypes, final ARecordType recordType, @@ -145,8 +145,8 @@ public class RecordWithMetadataAndPK<T> extends RecordWithPK<T> { throws IOException { if (length == 0) { if (!NonTaggedFormatUtil.isOptional(metaTypes[index])) { - throw new RuntimeDataException( - ErrorCode.INPUT_RECORD_RECORD_WITH_METADATA_AND_PK_NULL_IN_NON_OPTIONAL, index); + throw new RuntimeDataException(ErrorCode.INPUT_RECORD_RECORD_WITH_METADATA_AND_PK_NULL_IN_NON_OPTIONAL, + index); } fieldValueBufferOutputs[index].writeByte(ATypeTag.SERIALIZED_NULL_TYPE_TAG); } else { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java index f948c1c..e90b168 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java @@ -56,8 +56,8 @@ public class DCPMessageToRecordConverter implements IRecordToRecordWithMetadataA public DCPMessageToRecordConverter() { this.value = new CharArrayRecord(); - this.recordWithMetadata = new RecordWithMetadataAndPK<>(value, CB_META_TYPES, - RecordUtil.FULLY_OPEN_RECORD_TYPE, PK_INDICATOR, PK_INDEXES, PK_TYPES); + this.recordWithMetadata = new RecordWithMetadataAndPK<>(value, CB_META_TYPES, RecordUtil.FULLY_OPEN_RECORD_TYPE, + PK_INDICATOR, PK_INDEXES, PK_TYPES); } @Override http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/AbstractCharRecordLookupReader.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/AbstractCharRecordLookupReader.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/AbstractCharRecordLookupReader.java index f9ec114..6c7c42e 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/AbstractCharRecordLookupReader.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/AbstractCharRecordLookupReader.java @@ -64,7 +64,7 @@ public abstract class AbstractCharRecordLookupReader extends AbstractHDFSLookupR reusableByteBuffer.clear(); if (reusableByteBuffer.remaining() < value.getLength()) { reusableByteBuffer = ByteBuffer - .allocateDirect((int)(value.getLength() * ExternalDataConstants.DEFAULT_BUFFER_INCREMENT_FACTOR)); + .allocateDirect((int) (value.getLength() * ExternalDataConstants.DEFAULT_BUFFER_INCREMENT_FACTOR)); } reusableByteBuffer.put(value.getBytes(), 0, value.getLength()); reusableByteBuffer.flip(); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java index b847b23..1f97300 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/rss/RSSRecordReader.java @@ -106,7 +106,7 @@ public class RSSRecordReader implements IRecordReader<SyndEntry> { this.modified = modified; } - private SyndEntry getNextRSSFeed() throws IOException, FeedException, FetcherException { + private SyndEntry getNextRSSFeed() throws IOException, FeedException, FetcherException { if (rssFeedBuffer.isEmpty()) { fetchFeed(); } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java index e64c79e..07b6250 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java @@ -29,8 +29,8 @@ import org.apache.asterix.external.util.ExternalDataConstants; public class EmptyLineSeparatedRecordReader extends StreamRecordReader { - private static final List<String> recordReaderFormats = Collections - .unmodifiableList(Arrays.asList(ExternalDataConstants.FORMAT_LINE_SEPARATED)); + private static final List<String> recordReaderFormats = + Collections.unmodifiableList(Arrays.asList(ExternalDataConstants.FORMAT_LINE_SEPARATED)); private static final String REQUIRED_CONFIGS = ""; protected Map<String, String> config; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java index e1e1f08..cc4b7f9 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java @@ -39,9 +39,9 @@ public class SemiStructuredRecordReader extends StreamRecordReader { private char recordStart; private char recordEnd; private int recordNumber = 0; - private static final List<String> recordReaderFormats = Collections - .unmodifiableList(Arrays.asList(ExternalDataConstants.FORMAT_ADM, ExternalDataConstants.FORMAT_JSON, - ExternalDataConstants.FORMAT_SEMISTRUCTURED)); + private static final List<String> recordReaderFormats = + Collections.unmodifiableList(Arrays.asList(ExternalDataConstants.FORMAT_ADM, + ExternalDataConstants.FORMAT_JSON, ExternalDataConstants.FORMAT_SEMISTRUCTURED)); private static final String REQUIRED_CONFIGS = ""; @Override http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java index 0591775..776aa0c 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java @@ -94,8 +94,8 @@ public class StreamRecordReaderFactory implements IRecordReaderFactory<char[]> { public IRecordReader<? extends char[]> createRecordReader(IHyracksTaskContext ctx, int partition) throws HyracksDataException { try { - StreamRecordReader streamRecordReader = (StreamRecordReader) recordReaderClazz.getConstructor() - .newInstance(); + StreamRecordReader streamRecordReader = + (StreamRecordReader) recordReaderClazz.getConstructor().newInstance(); streamRecordReader.configure(streamFactory.createInputStream(ctx, partition), configuration); return streamRecordReader; } catch (InstantiationException | IllegalAccessException | InvocationTargetException http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java index 0b9c4a2..49d851d 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java @@ -40,8 +40,7 @@ public class TwitterFirehoseInputStream extends AsterixInputStream { private final DataProvider dataProvider; private boolean started; - public TwitterFirehoseInputStream(Map<String, String> configuration, int partition) - throws IOException { + public TwitterFirehoseInputStream(Map<String, String> configuration, int partition) throws IOException { executorService = Executors.newCachedThreadPool(); outputStream = new PipedOutputStream(); inputStream = new PipedInputStream(outputStream); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java index c644413..63028ac 100755 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java @@ -56,8 +56,7 @@ public abstract class ExternalFunction implements IExternalFunction { protected final JavaFunctionHelper functionHelper; public ExternalFunction(IExternalFunctionInfo finfo, IScalarEvaluatorFactory args[], IHyracksTaskContext context, - IApplicationContext appCtx) - throws HyracksDataException { + IApplicationContext appCtx) throws HyracksDataException { this.finfo = finfo; this.evaluatorFactories = args; argumentEvaluators = new IScalarEvaluator[args.length]; @@ -78,8 +77,7 @@ public abstract class ExternalFunction implements IExternalFunction { externalFunctionFactory = (IFunctionFactory) clazz.newInstance(); externalFunction = externalFunctionFactory.getExternalFunction(); } catch (Exception e) { - throw new RuntimeDataException(ErrorCode.LIBRARY_EXTERNAL_FUNCTION_UNABLE_TO_LOAD_CLASS, e, - classname); + throw new RuntimeDataException(ErrorCode.LIBRARY_EXTERNAL_FUNCTION_UNABLE_TO_LOAD_CLASS, e, classname); } } http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java index 916e668..bc53f0b 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java @@ -47,7 +47,6 @@ import org.apache.asterix.om.types.AUnorderedListType; import org.apache.asterix.om.types.IAType; import org.apache.asterix.om.util.container.IObjectFactory; - public class JTypeObjectFactory implements IObjectFactory<IJObject, IAType> { public static final JTypeObjectFactory INSTANCE = new JTypeObjectFactory(); http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java index a369888..617bbbc 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java @@ -52,8 +52,8 @@ public class JavaFunctionHelper implements IFunctionHelper { private final IDataOutputProvider outputProvider; private final IJObject[] arguments; private IJObject resultHolder; - private final IObjectPool<IJObject, IAType> objectPool = new ListObjectPool<IJObject, IAType>( - JTypeObjectFactory.INSTANCE); + private final IObjectPool<IJObject, IAType> objectPool = + new ListObjectPool<IJObject, IAType>(JTypeObjectFactory.INSTANCE); private final JObjectPointableVisitor pointableVisitor; private final PointableAllocator pointableAllocator; private final Map<Integer, TypeInfo> poolTypeInfo; http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectPointableVisitor.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectPointableVisitor.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectPointableVisitor.java index dc8e461..960b346 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectPointableVisitor.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectPointableVisitor.java @@ -41,8 +41,10 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; public class JObjectPointableVisitor implements IVisitablePointableVisitor<IJObject, TypeInfo> { private final Map<ATypeTag, IJObjectAccessor> flatJObjectAccessors = new HashMap<ATypeTag, IJObjectAccessor>(); - private final Map<IVisitablePointable, IJRecordAccessor> raccessorToJObject = new HashMap<IVisitablePointable, IJRecordAccessor>(); - private final Map<IVisitablePointable, IJListAccessor> laccessorToPrinter = new HashMap<IVisitablePointable, IJListAccessor>(); + private final Map<IVisitablePointable, IJRecordAccessor> raccessorToJObject = + new HashMap<IVisitablePointable, IJRecordAccessor>(); + private final Map<IVisitablePointable, IJListAccessor> laccessorToPrinter = + new HashMap<IVisitablePointable, IJListAccessor>(); @Override public IJObject visit(AListVisitablePointable accessor, TypeInfo arg) throws HyracksDataException { http://git-wip-us.apache.org/repos/asf/asterixdb/blob/cb9ca975/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java ---------------------------------------------------------------------- diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java index d964788..c0ccf11 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java @@ -65,12 +65,12 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars private final ArrayBackedValueStorage castBuffer = new ArrayBackedValueStorage(); - private final IObjectPool<IARecordBuilder, ATypeTag> recordBuilderPool = new ListObjectPool<IARecordBuilder, ATypeTag>( - new RecordBuilderFactory()); - private final IObjectPool<IAsterixListBuilder, ATypeTag> listBuilderPool = new ListObjectPool<IAsterixListBuilder, ATypeTag>( - new ListBuilderFactory()); - private final IObjectPool<IMutableValueStorage, ATypeTag> abvsBuilderPool = new ListObjectPool<IMutableValueStorage, ATypeTag>( - new AbvsBuilderFactory()); + private final IObjectPool<IARecordBuilder, ATypeTag> recordBuilderPool = + new ListObjectPool<IARecordBuilder, ATypeTag>(new RecordBuilderFactory()); + private final IObjectPool<IAsterixListBuilder, ATypeTag> listBuilderPool = + new ListObjectPool<IAsterixListBuilder, ATypeTag>(new ListBuilderFactory()); + private final IObjectPool<IMutableValueStorage, ATypeTag> abvsBuilderPool = + new ListObjectPool<IMutableValueStorage, ATypeTag>(new AbvsBuilderFactory()); private final String mismatchErrorMessage = "Mismatch Type, expecting a value of type "; private final String mismatchErrorMessage2 = " got a value of type "; @@ -198,8 +198,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars if (checkType(ATypeTag.BOOLEAN, objectType)) { booleanSerde.serialize(ABoolean.TRUE, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_BOOLEAN_CONS: @@ -209,8 +208,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars if (checkType(ATypeTag.BOOLEAN, objectType)) { booleanSerde.serialize(ABoolean.FALSE, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_DOUBLE_LITERAL: @@ -256,19 +254,18 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars break; case AdmLexer.TOKEN_STRING_LITERAL: if (checkType(ATypeTag.STRING, objectType)) { - String tokenImage = admLexer.getLastTokenImage().substring(1, - admLexer.getLastTokenImage().length() - 1); + String tokenImage = + admLexer.getLastTokenImage().substring(1, admLexer.getLastTokenImage().length() - 1); aString.setValue(admLexer.containsEscapes() ? replaceEscapes(tokenImage) : tokenImage); stringSerde.serialize(aString, out); } else if (checkType(ATypeTag.UUID, objectType)) { // Dealing with UUID type that is represented by a string - String tokenImage = admLexer.getLastTokenImage().substring(1, - admLexer.getLastTokenImage().length() - 1); + String tokenImage = + admLexer.getLastTokenImage().substring(1, admLexer.getLastTokenImage().length() - 1); aUUID.parseUUIDString(tokenImage); uuidSerde.serialize(aUUID, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_STRING_CONS: @@ -286,8 +283,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars } } } - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); case AdmLexer.TOKEN_DATE_CONS: parseConstructor(ATypeTag.DATE, objectType, out); break; @@ -302,8 +298,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars objectType = getComplexType(objectType, ATypeTag.INTERVAL); parseInterval(ATypeTag.INTERVAL, objectType, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_DURATION_CONS: @@ -338,8 +333,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars objectType = getComplexType(objectType, ATypeTag.MULTISET); parseUnorderedList((AUnorderedListType) objectType, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_START_ORDERED_LIST: @@ -347,8 +341,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars objectType = getComplexType(objectType, ATypeTag.ARRAY); parseOrderedList((AOrderedListType) objectType, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_START_RECORD: @@ -356,8 +349,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars objectType = getComplexType(objectType, ATypeTag.OBJECT); parseRecord((ARecordType) objectType, out); } else { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, - objectType.getTypeName()); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_TYPE_MISMATCH, objectType.getTypeName()); } break; case AdmLexer.TOKEN_UUID_CONS: @@ -407,8 +399,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars readpos += 4; break; default: - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_ILLEGAL_ESCAPE, - chars[readpos + 1]); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_ILLEGAL_ESCAPE, chars[readpos + 1]); } ++readpos; movemarker = readpos + 1; @@ -517,12 +508,12 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars expectingRecordField = false; if (recType != null) { - String fldName = admLexer.getLastTokenImage().substring(1, - admLexer.getLastTokenImage().length() - 1); + String fldName = + admLexer.getLastTokenImage().substring(1, admLexer.getLastTokenImage().length() - 1); fieldId = recBuilder.getFieldId(fldName); if ((fieldId < 0) && !recType.isOpen()) { - throw new ParseException( - ErrorCode.PARSER_ADM_DATA_PARSER_EXTRA_FIELD_IN_CLOSED_RECORD, fldName); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_EXTRA_FIELD_IN_CLOSED_RECORD, + fldName); } else if ((fieldId < 0) && recType.isOpen()) { aStringFieldName.setValue(admLexer.getLastTokenImage().substring(1, admLexer.getLastTokenImage().length() - 1)); @@ -545,8 +536,7 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars token = admLexer.next(); if (token != AdmLexer.TOKEN_COLON) { - throw new ParseException( - ErrorCode.PARSER_ADM_DATA_PARSER_UNEXPECTED_TOKEN_WHEN_EXPECT_COMMA, + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_UNEXPECTED_TOKEN_WHEN_EXPECT_COMMA, AdmLexer.tokenKindToString(token)); } @@ -561,12 +551,10 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars break; case AdmLexer.TOKEN_COMMA: if (first) { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_FOUND_COMMA_WHEN, - "before any"); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_FOUND_COMMA_WHEN, "before any"); } if (expectingRecordField) { - throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_FOUND_COMMA_WHEN, - "expecting a"); + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_FOUND_COMMA_WHEN, "expecting a"); } expectingRecordField = true; break; @@ -675,8 +663,8 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars String arg = admLexer.getLastTokenImage(); switch (tag) { case DATE: - chrononTimeInMs += (parseDatePart(arg, 0, arg.length() - 1) - / GregorianCalendarSystem.CHRONON_OF_DAY); + chrononTimeInMs += + (parseDatePart(arg, 0, arg.length() - 1) / GregorianCalendarSystem.CHRONON_OF_DAY); break; case TIME: chrononTimeInMs += parseTimePart(arg, 0, arg.length() - 1); @@ -687,8 +675,8 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_INTERVAL_INVALID_DATETIME); } chrononTimeInMs += parseDatePart(arg, 0, timeSeperatorOffsetInDatetimeString - 1); - chrononTimeInMs += parseTimePart(arg, timeSeperatorOffsetInDatetimeString + 1, - arg.length() - 1); + chrononTimeInMs += + parseTimePart(arg, timeSeperatorOffsetInDatetimeString + 1, arg.length() - 1); break; default: throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_INTERVAL_UNSUPPORTED_TYPE); @@ -874,18 +862,17 @@ public class ADMDataParser extends AbstractDataParser implements IStreamDataPars if (token == AdmLexer.TOKEN_CONSTRUCTOR_OPEN) { token = admLexer.next(); if (token == AdmLexer.TOKEN_STRING_LITERAL) { - String unquoted = admLexer.getLastTokenImage().substring(1, - admLexer.getLastTokenImage().length() - 1); + String unquoted = + admLexer.getLastTokenImage().substring(1, admLexer.getLastTokenImage().length() - 1); if (!parseValue(unquoted, typeTag, dataOutput)) { - throw new ParseException( - ErrorCode.PARSER_ADM_DATA_PARSER_CONSTRUCTOR_MISSING_DESERIALIZER, + throw new ParseException(ErrorCode.PARSER_ADM_DATA_PARSER_CONSTRUCTOR_MISSING_DESERIALIZER, AdmLexer.tokenKindToString(token)); } token = admLexer.next(); if (token == AdmLexer.TOKEN_CONSTRUCTOR_CLOSE) { if (targetTypeTag != typeTag) { - ITypeConvertComputer promoteComputer = ATypeHierarchy.getTypePromoteComputer(typeTag, - targetTypeTag); + ITypeConvertComputer promoteComputer = + ATypeHierarchy.getTypePromoteComputer(typeTag, targetTypeTag); // the availability if the promote computer should be consistent with // the availability of a target type assert promoteComputer != null;
