Pass executor context and client id to extention statements Change-Id: I1395817df00917bd9b4d5676d4f2cea3888b7221
Project: http://git-wip-us.apache.org/repos/asf/asterixdb-bad/repo Commit: http://git-wip-us.apache.org/repos/asf/asterixdb-bad/commit/40b70a18 Tree: http://git-wip-us.apache.org/repos/asf/asterixdb-bad/tree/40b70a18 Diff: http://git-wip-us.apache.org/repos/asf/asterixdb-bad/diff/40b70a18 Branch: refs/heads/resultsFinalVersion Commit: 40b70a18ab849cf7403cacdfdd47c14da24fffb0 Parents: 8c940db Author: Abdullah Alamoudi <[email protected]> Authored: Wed Jul 18 08:50:24 2018 -0700 Committer: Abdullah Alamoudi <[email protected]> Committed: Wed Jul 18 08:50:24 2018 -0700 ---------------------------------------------------------------------- .../apache/asterix/bad/lang/BADStatementExecutor.java | 7 +++---- .../bad/lang/statement/BrokerDropStatement.java | 5 +++-- .../bad/lang/statement/ChannelDropStatement.java | 10 +++++----- .../bad/lang/statement/ChannelSubscribeStatement.java | 5 +++-- .../lang/statement/ChannelUnsubscribeStatement.java | 8 ++++---- .../bad/lang/statement/CreateBrokerStatement.java | 5 +++-- .../bad/lang/statement/CreateChannelStatement.java | 8 ++++---- .../bad/lang/statement/CreateProcedureStatement.java | 14 ++++++-------- .../bad/lang/statement/ExecuteProcedureStatement.java | 13 ++++++------- .../bad/lang/statement/ProcedureDropStatement.java | 10 +++++----- 10 files changed, 42 insertions(+), 43 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java index b95ca11..1a5fc34 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java @@ -250,7 +250,6 @@ public class BADStatementExecutor extends QueryTranslator { metadataProvider.getLocks().unlock(); } - } @Override @@ -343,7 +342,7 @@ public class BADStatementExecutor extends QueryTranslator { tempMdProvider.getLocks().reset(); ChannelDropStatement drop = new ChannelDropStatement(dvId, new Identifier(channel.getChannelId().getEntityName()), false); - drop.handle(hcc, this, requestParameters, tempMdProvider, 0); + drop.handle(hcc, this, requestParameters, tempMdProvider, 0, null); } for (Procedure procedure : procedures) { if (!procedure.getEntityId().getDataverse().equals(dvId.getValue())) { @@ -352,13 +351,13 @@ public class BADStatementExecutor extends QueryTranslator { tempMdProvider.getLocks().reset(); ProcedureDropStatement drop = new ProcedureDropStatement(new FunctionSignature(dvId.getValue(), procedure.getEntityId().getEntityName(), procedure.getArity()), false); - drop.handle(hcc, this, requestParameters, tempMdProvider, 0); + drop.handle(hcc, this, requestParameters, tempMdProvider, 0, null); } List<Broker> brokers = BADLangExtension.getBrokers(mdTxnCtx, dvId.getValue()); for (Broker broker : brokers) { tempMdProvider.getLocks().reset(); BrokerDropStatement drop = new BrokerDropStatement(dvId, new Identifier(broker.getBrokerName()), false); - drop.handle(hcc, this, requestParameters, tempMdProvider, 0); + drop.handle(hcc, this, requestParameters, tempMdProvider, 0, null); } MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); super.handleDataverseDropStatement(metadataProvider, stmt, hcc); http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java index 4f68f40..b2b38ab 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java @@ -30,6 +30,7 @@ import org.apache.asterix.metadata.MetadataTransactionContext; import org.apache.asterix.metadata.declared.MetadataProvider; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.api.client.IHyracksClientConnection; import org.apache.hyracks.api.exceptions.HyracksDataException; @@ -70,8 +71,8 @@ public class BrokerDropStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { //TODO: dont drop a broker that's being used String dataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(dataverseName); MetadataTransactionContext mdTxnCtx = null; http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java index 8403fcc..d778215 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java @@ -40,6 +40,7 @@ import org.apache.asterix.metadata.MetadataTransactionContext; import org.apache.asterix.metadata.declared.MetadataProvider; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.api.client.IHyracksClientConnection; import org.apache.hyracks.api.exceptions.HyracksDataException; @@ -82,8 +83,8 @@ public class ChannelDropStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { String dataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(dataverseName); boolean txnActive = false; EntityId entityId = new EntityId(BADConstants.CHANNEL_EXTENSION_NAME, dataverse, channelName.getValue()); @@ -111,9 +112,8 @@ public class ChannelDropStatement extends ExtensionStatement { if (listener == null) { //TODO: Channels need to better handle cluster failures LOGGER.log(Level.SEVERE, - "Tried to drop a Deployed Job whose listener no longer exists: " - + entityId.getExtensionName() + " " + entityId.getDataverse() + "." - + entityId.getEntityName() + "."); + "Tried to drop a Deployed Job whose listener no longer exists: " + entityId.getExtensionName() + + " " + entityId.getDataverse() + "." + entityId.getEntityName() + "."); } else { listener.getExecutorService().shutdown(); http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java index 7583f0b..cff1eaa 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java @@ -52,6 +52,7 @@ import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; import org.apache.asterix.translator.IStatementExecutor.ResultDelivery; import org.apache.asterix.translator.IStatementExecutor.Stats; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier; import org.apache.hyracks.api.client.IHyracksClientConnection; @@ -120,8 +121,8 @@ public class ChannelSubscribeStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { String dataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(dataverseName); String brokerDataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(brokerDataverseName); http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java index b23bf3b..774ca86 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java @@ -46,6 +46,7 @@ import org.apache.asterix.metadata.declared.MetadataProvider; import org.apache.asterix.om.functions.BuiltinFunctions; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier; import org.apache.hyracks.api.client.IHyracksClientConnection; @@ -100,8 +101,8 @@ public class ChannelUnsubscribeStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { String dataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(dataverseName); MetadataTransactionContext mdTxnCtx = null; @@ -139,8 +140,7 @@ public class ChannelUnsubscribeStatement extends ExtensionStatement { MetadataProvider tempMdProvider = new MetadataProvider(metadataProvider.getApplicationContext(), metadataProvider.getDefaultDataverse()); tempMdProvider.getConfig().putAll(metadataProvider.getConfig()); - ((QueryTranslator) statementExecutor).handleDeleteStatement(tempMdProvider, delete, hcc, false, null, - null); + ((QueryTranslator) statementExecutor).handleDeleteStatement(tempMdProvider, delete, hcc, false, null, null); MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); } catch (Exception e) { QueryTranslator.abort(e, e, mdTxnCtx); http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java index 367599b..0f01a66 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java @@ -33,6 +33,7 @@ import org.apache.asterix.metadata.MetadataTransactionContext; import org.apache.asterix.metadata.declared.MetadataProvider; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.api.client.IHyracksClientConnection; import org.apache.hyracks.api.exceptions.HyracksDataException; @@ -74,8 +75,8 @@ public class CreateBrokerStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { String dataverse = ((QueryTranslator) statementExecutor).getActiveDataverse(dataverseName); MetadataTransactionContext mdTxnCtx = null; try { http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java index a28666a..edadeb6 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java @@ -68,6 +68,7 @@ import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; import org.apache.asterix.translator.IStatementExecutor.ResultDelivery; import org.apache.asterix.translator.IStatementExecutor.Stats; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.algebricks.common.utils.Pair; import org.apache.hyracks.api.client.IHyracksClientConnection; @@ -138,8 +139,7 @@ public class CreateChannelStatement extends ExtensionStatement { return null; } - public void initialize(MetadataTransactionContext mdTxnCtx) - throws AlgebricksException, HyracksDataException { + public void initialize(MetadataTransactionContext mdTxnCtx) throws AlgebricksException, HyracksDataException { Function lookup = MetadataManager.INSTANCE.getFunction(mdTxnCtx, function); if (lookup == null) { throw new MetadataException(" Unknown function " + function.getName()); @@ -258,8 +258,8 @@ public class CreateChannelStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestContext, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestContext, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { //This function performs three tasks: //1. Create datasets for the Channel //2. Create and run the Channel Job http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java index aaf2bfa..6459b4c 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java @@ -69,6 +69,7 @@ import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; import org.apache.asterix.translator.IStatementExecutor.ResultDelivery; import org.apache.asterix.translator.IStatementExecutor.Stats; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.algebricks.common.utils.Pair; import org.apache.hyracks.api.client.IHyracksClientConnection; @@ -175,8 +176,7 @@ public class CreateProcedureStatement extends ExtensionStatement { } private Pair<JobSpecification, PrecompiledType> createProcedureJob(IStatementExecutor statementExecutor, - MetadataProvider metadataProvider, IHyracksClientConnection hcc, Stats stats) - throws Exception { + MetadataProvider metadataProvider, IHyracksClientConnection hcc, Stats stats) throws Exception { if (getProcedureBodyStatement().getKind() == Statement.Kind.INSERT) { if (!varList.isEmpty()) { throw new CompilationException("Insert procedures cannot have parameters"); @@ -193,8 +193,7 @@ public class CreateProcedureStatement extends ExtensionStatement { dependencies.get(1).addAll(FunctionUtil.getFunctionDependencies(fact.createQueryRewriter(), ((Query) getProcedureBodyStatement()).getBody(), metadataProvider).get(1)); Pair<JobSpecification, PrecompiledType> pair = new Pair<>(BADJobService.compileQueryJob(statementExecutor, - metadataProvider, hcc, (Query) getProcedureBodyStatement()), - PrecompiledType.QUERY); + metadataProvider, hcc, (Query) getProcedureBodyStatement()), PrecompiledType.QUERY); dependencies.get(0).addAll(FunctionUtil.getFunctionDependencies(fact.createQueryRewriter(), ((Query) getProcedureBodyStatement()).getBody(), metadataProvider).get(0)); return pair; @@ -216,8 +215,7 @@ public class CreateProcedureStatement extends ExtensionStatement { } private void setupDeployedJobSpec(EntityId entityId, JobSpecification jobSpec, IHyracksClientConnection hcc, - DeployedJobSpecEventListener listener, ResultSetId resultSetId, Stats stats) - throws Exception { + DeployedJobSpecEventListener listener, ResultSetId resultSetId, Stats stats) throws Exception { jobSpec.setProperty(ActiveNotificationHandler.ACTIVE_ENTITY_PROPERTY_NAME, entityId); DeployedJobSpecId deployedJobSpecId = hcc.deployJobSpec(jobSpec); listener.setDeployedJobSpecId(deployedJobSpecId); @@ -225,8 +223,8 @@ public class CreateProcedureStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { ICcApplicationContext appCtx = metadataProvider.getApplicationContext(); ActiveNotificationHandler activeEventHandler = (ActiveNotificationHandler) appCtx.getActiveNotificationHandler(); http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java index b794538..69f413e 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java @@ -50,6 +50,7 @@ import org.apache.asterix.om.base.IAObject; import org.apache.asterix.translator.ConstantHelper; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.api.client.IHyracksClientConnection; import org.apache.hyracks.api.exceptions.HyracksDataException; @@ -96,8 +97,8 @@ public class ExecuteProcedureStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { ICcApplicationContext appCtx = metadataProvider.getApplicationContext(); ActiveNotificationHandler activeEventHandler = (ActiveNotificationHandler) appCtx.getActiveNotificationHandler(); @@ -119,9 +120,8 @@ public class ExecuteProcedureStatement extends ExtensionStatement { DeployedJobSpecId deployedJobSpecId = listener.getDeployedJobSpecId(); if (procedure.getDuration().equals("")) { BADJobService.runDeployedJobSpec(deployedJobSpecId, hcc, requestParameters.getHyracksDataset(), - contextRuntimeVarMap, entityId, - metadataProvider.getTxnIdFactory(), appCtx, listener, (QueryTranslator) statementExecutor); - + contextRuntimeVarMap, entityId, metadataProvider.getTxnIdFactory(), appCtx, listener, + (QueryTranslator) statementExecutor); } else { ScheduledExecutorService ses = BADJobService.startRepetitiveDeployedJobSpec(deployedJobSpecId, hcc, @@ -142,8 +142,7 @@ public class ExecuteProcedureStatement extends ExtensionStatement { } } - private Map<byte[], byte[]> createParameterMap(Procedure procedure) - throws AsterixException, HyracksDataException { + private Map<byte[], byte[]> createParameterMap(Procedure procedure) throws AsterixException, HyracksDataException { Map<byte[], byte[]> map = new HashMap<>(); if (procedure.getParams().size() != argList.size()) { throw AsterixException.create(ErrorCode.COMPILATION_INVALID_PARAMETER_NUMBER, http://git-wip-us.apache.org/repos/asf/asterixdb-bad/blob/40b70a18/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java ---------------------------------------------------------------------- diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java index 95531bd..7a1cfd0 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java @@ -40,6 +40,7 @@ import org.apache.asterix.metadata.MetadataTransactionContext; import org.apache.asterix.metadata.declared.MetadataProvider; import org.apache.asterix.translator.IRequestParameters; import org.apache.asterix.translator.IStatementExecutor; +import org.apache.asterix.translator.IStatementExecutorContext; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; import org.apache.hyracks.api.client.IHyracksClientConnection; import org.apache.hyracks.api.exceptions.HyracksDataException; @@ -76,8 +77,8 @@ public class ProcedureDropStatement extends ExtensionStatement { @Override public void handle(IHyracksClientConnection hcc, IStatementExecutor statementExecutor, - IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId) - throws HyracksDataException, AlgebricksException { + IRequestParameters requestParameters, MetadataProvider metadataProvider, int resultSetId, + IStatementExecutorContext executorCtx) throws HyracksDataException, AlgebricksException { ICcApplicationContext appCtx = metadataProvider.getApplicationContext(); ActiveNotificationHandler activeEventHandler = (ActiveNotificationHandler) appCtx.getActiveNotificationHandler(); @@ -115,9 +116,8 @@ public class ProcedureDropStatement extends ExtensionStatement { if (listener == null) { //TODO: Channels need to better handle cluster failures LOGGER.log(Level.SEVERE, - "Tried to drop a Deployed Job whose listener no longer exists: " - + entityId.getExtensionName() + " " + entityId.getDataverse() + "." - + entityId.getEntityName() + "."); + "Tried to drop a Deployed Job whose listener no longer exists: " + entityId.getExtensionName() + + " " + entityId.getDataverse() + "." + entityId.getEntityName() + "."); } else { if (listener.getExecutorService() != null) { listener.getExecutorService().shutdown();
