This is an automated email from the ASF dual-hosted git repository.
mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 7b81d19 [NO ISSUE][OTH] Skip Calling Job Result Callback For Unknown
Jobs
7b81d19 is described below
commit 7b81d193ed5b8b24c31ae37e5cde6362cbf07152
Author: Murtadha Hubail <[email protected]>
AuthorDate: Fri Jun 14 02:54:13 2019 +0300
[NO ISSUE][OTH] Skip Calling Job Result Callback For Unknown Jobs
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Skip calling the job result callback on a job's completion
when the job's result record is not found. This can happen
if a job's execution time exceeds the result's TTL in which
case we remove the job's result reference.
Change-Id: I7ba09da4292213b63d2396d21969329e86634c06
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3439
Contrib: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Integration-Tests: Jenkins <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
Reviewed-by: Hussain Towaileb <[email protected]>
---
.../org/apache/hyracks/control/cc/result/ResultDirectoryService.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
index bfecc48..9f8a7e2 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
@@ -96,7 +96,10 @@ public class ResultDirectoryService extends
AbstractResultManager implements IRe
@Override
public void notifyJobFinish(JobId jobId, JobStatus jobStatus,
List<Exception> exceptions) throws HyracksException {
if (exceptions == null || exceptions.isEmpty()) {
- final ResultJobRecord resultJobRecord =
getNonNullResultJobRecord(jobId);
+ final ResultJobRecord resultJobRecord = getResultJobRecord(jobId);
+ if (resultJobRecord == null) {
+ return;
+ }
resultJobRecord.finish();
jobResultCallback.completed(jobId, resultJobRecord);
}
