This is an automated email from the ASF dual-hosted git repository. mblow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit af44111696e833fec220e2c634879a6811407ef5 Author: Michael Blow <[email protected]> AuthorDate: Fri Dec 27 12:18:42 2019 -0500 [NO ISSUE] Address serialVersionUID issues - add missing serialVersionUIDs where applicable - add @SuppressWarnings("serial") for serializable types which are never actually serialized Change-Id: Ic38d33b8020c3261bda4ebb0b273b26c40fef26f Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4523 Reviewed-by: Michael Blow <[email protected]> Reviewed-by: Till Westmann <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> --- .../src/main/java/org/apache/asterix/translator/IStatementExecutor.java | 2 ++ .../src/main/java/org/apache/asterix/api/common/ResultMetadata.java | 1 + .../main/java/org/apache/asterix/app/result/fields/ProfilePrinter.java | 1 + .../input/record/reader/http/HttpServerRecordReaderFactory.java | 1 + .../src/main/java/org/apache/asterix/lang/sqlpp/parser/SqlppToken.java | 1 + .../src/main/java/org/apache/asterix/metadata/RMIClientFactory.java | 1 + .../asterix/runtime/evaluators/functions/bitwise/BitAndDescriptor.java | 1 + .../runtime/evaluators/functions/bitwise/BitClearDescriptor.java | 1 + .../runtime/evaluators/functions/bitwise/BitCountDescriptor.java | 1 + .../asterix/runtime/evaluators/functions/bitwise/BitNotDescriptor.java | 1 + .../asterix/runtime/evaluators/functions/bitwise/BitOrDescriptor.java | 1 + .../asterix/runtime/evaluators/functions/bitwise/BitSetDescriptor.java | 1 + .../evaluators/functions/bitwise/BitShiftWithRotateFlagDescriptor.java | 1 + .../functions/bitwise/BitShiftWithoutRotateFlagDescriptor.java | 1 + .../evaluators/functions/bitwise/BitTestWithAllFlagDescriptor.java | 1 + .../evaluators/functions/bitwise/BitTestWithoutAllFlagDescriptor.java | 1 + .../asterix/runtime/evaluators/functions/bitwise/BitXorDescriptor.java | 1 + .../evaluators/functions/bitwise/IsBitSetWithAllFlagDescriptor.java | 1 + .../evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java | 1 + .../core/algebra/prettyprint/AlgebricksStringBuilderWriter.java | 1 + 20 files changed, 21 insertions(+) diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java index 3fdcc33..e7fec0c 100644 --- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java +++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java @@ -189,6 +189,8 @@ public interface IStatementExecutor { } class Profile implements Serializable { + private static final long serialVersionUID = 4813321148252768375L; + private transient ObjectNode profile; public Profile(ObjectNode profile) { diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/ResultMetadata.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/ResultMetadata.java index e5ed091..35e8daf 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/ResultMetadata.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/ResultMetadata.java @@ -27,6 +27,7 @@ import org.apache.hyracks.api.result.IResultMetadata; import com.fasterxml.jackson.databind.node.ObjectNode; public class ResultMetadata implements IResultMetadata { + private static final long serialVersionUID = 1905367559307369034L; private final SessionConfig.OutputFormat format; private long jobDuration; diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ProfilePrinter.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ProfilePrinter.java index d74d25c..bb835ff 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ProfilePrinter.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ProfilePrinter.java @@ -49,6 +49,7 @@ public class ProfilePrinter implements IResponseFieldPrinter { pw.print("\t\"" + FIELD_NAME + "\" : "); ObjectMapper om = new ObjectMapper(); om.disable(JsonGenerator.Feature.AUTO_CLOSE_TARGET); + @SuppressWarnings("serial") DefaultIndenter ind = new DefaultIndenter("\t", DefaultIndenter.SYS_LF) { @Override public void writeIndentation(JsonGenerator jg, int level) throws IOException { diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java index 944948b..d14071f 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java @@ -36,6 +36,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; import org.apache.hyracks.http.server.HttpServerConfigBuilder; public class HttpServerRecordReaderFactory implements IRecordReaderFactory<char[]> { + private static final long serialVersionUID = -66399726369366305L; private static final String KEY_CONFIGURATION_ADDRESSES = "addresses"; private static final String KEY_CONFIGURATION_PATH = "path"; diff --git a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/SqlppToken.java b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/SqlppToken.java index 13dca02..3669ae0 100644 --- a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/SqlppToken.java +++ b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/SqlppToken.java @@ -24,6 +24,7 @@ import java.io.Serializable; import org.apache.hyracks.api.exceptions.SourceLocation; public abstract class SqlppToken implements Serializable { + private static final long serialVersionUID = -2974917383986695694L; public SourceLocation sourceLocation; diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/RMIClientFactory.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/RMIClientFactory.java index dd0c028..ac2ecd0 100644 --- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/RMIClientFactory.java +++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/RMIClientFactory.java @@ -28,6 +28,7 @@ import javax.net.SocketFactory; import javax.net.ssl.SSLSocketFactory; public class RMIClientFactory implements RMIClientSocketFactory, Serializable { + private static final long serialVersionUID = -3874278041718817394L; private final boolean sslEnabled; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitAndDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitAndDescriptor.java index 1c8b9dc..ef509fa 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitAndDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitAndDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitAndDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -140697639709011259L; public static final IFunctionDescriptorFactory FACTORY = BitAndDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java index 414f6a0..e3f9fd8 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitClearDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -1790134294538449161L; public static final IFunctionDescriptorFactory FACTORY = BitClearDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitCountDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitCountDescriptor.java index 8daa6b0..df30f3e 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitCountDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitCountDescriptor.java @@ -36,6 +36,7 @@ import org.apache.hyracks.data.std.api.IPointable; @MissingNullInOutFunction public class BitCountDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -6355679338952487274L; public static final IFunctionDescriptorFactory FACTORY = BitCountDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitNotDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitNotDescriptor.java index 1fbbaf4..31d62a4 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitNotDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitNotDescriptor.java @@ -36,6 +36,7 @@ import org.apache.hyracks.data.std.api.IPointable; @MissingNullInOutFunction public class BitNotDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = 549770812101511988L; public static final IFunctionDescriptorFactory FACTORY = BitNotDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitOrDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitOrDescriptor.java index d11b6af..37d231a 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitOrDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitOrDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitOrDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = 3096119314615759635L; public static final IFunctionDescriptorFactory FACTORY = BitOrDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitSetDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitSetDescriptor.java index e72853d..e38fefc 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitSetDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitSetDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitSetDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -5710185389455313462L; public static final IFunctionDescriptorFactory FACTORY = BitSetDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithRotateFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithRotateFlagDescriptor.java index 6a59a6f..c8765ad 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithRotateFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithRotateFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitShiftWithRotateFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -2277131079446466053L; public static final IFunctionDescriptorFactory FACTORY = BitShiftWithRotateFlagDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithoutRotateFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithoutRotateFlagDescriptor.java index 897b143..45422da 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithoutRotateFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitShiftWithoutRotateFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitShiftWithoutRotateFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -2654547496459449684L; public static final IFunctionDescriptorFactory FACTORY = BitShiftWithoutRotateFlagDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithAllFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithAllFlagDescriptor.java index 5398e6b..c3741b2 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithAllFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithAllFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitTestWithAllFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -2668646200589547517L; public static final IFunctionDescriptorFactory FACTORY = BitTestWithAllFlagDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithoutAllFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithoutAllFlagDescriptor.java index a2662c3..ae9519b 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithoutAllFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitTestWithoutAllFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitTestWithoutAllFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -3124196321567262353L; public static final IFunctionDescriptorFactory FACTORY = BitTestWithoutAllFlagDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitXorDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitXorDescriptor.java index edd1dcf..944f129 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitXorDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitXorDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class BitXorDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -1803337858721065395L; public static final IFunctionDescriptorFactory FACTORY = BitXorDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithAllFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithAllFlagDescriptor.java index f1cb704..5592342 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithAllFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithAllFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class IsBitSetWithAllFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -2899093161460352528L; public static final IFunctionDescriptorFactory FACTORY = IsBitSetWithAllFlagDescriptor::new; diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java index e7cd674..0c4a326 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/IsBitSetWithoutAllFlagDescriptor.java @@ -31,6 +31,7 @@ import org.apache.hyracks.api.exceptions.HyracksDataException; @MissingNullInOutFunction public class IsBitSetWithoutAllFlagDescriptor extends AbstractScalarFunctionDynamicDescriptor { + private static final long serialVersionUID = -1733575449220258856L; public static final IFunctionDescriptorFactory FACTORY = IsBitSetWithoutAllFlagDescriptor::new; diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksStringBuilderWriter.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksStringBuilderWriter.java index 2444ce8..f704dc0 100644 --- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksStringBuilderWriter.java +++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AlgebricksStringBuilderWriter.java @@ -29,6 +29,7 @@ import org.apache.hyracks.util.annotations.NotThreadSafe; */ @NotThreadSafe public class AlgebricksStringBuilderWriter extends StringBuilderWriter { + private static final long serialVersionUID = 61841252848797632L; public AlgebricksStringBuilderWriter() { super();
