This is an automated email from the ASF dual-hosted git repository. mblow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit df7c02d77f907a1e587f297e511e43f7d697785f Author: Murtadha Hubail <[email protected]> AuthorDate: Thu Mar 12 03:47:35 2020 +0300 [NO ISSUE][OTH] Extensible Servlet Requests - user model changes: no - storage format changes: no - interface changes: no Details: - Allow extentions to create their own Servlet Requests in http servers. Change-Id: I71eeaaaf4fb30a51059b9cf6399c19bcec6b40ec Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/5306 Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Reviewed-by: Michael Blow <[email protected]> --- .../java/org/apache/hyracks/http/server/HttpServerHandler.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java index 0f4ce8a..77d3493 100644 --- a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java +++ b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java @@ -146,7 +146,7 @@ public class HttpServerHandler<T extends HttpServer> extends SimpleChannelInboun HttpScheme scheme = server.getScheme() == HttpScheme.HTTPS || "https".equals(request.headers().get(X_FORWARDED_PROTO)) ? HttpScheme.HTTPS : HttpScheme.HTTP; - servletRequest = HttpUtil.toServletRequest(ctx, request, scheme); + servletRequest = createServletRequest(ctx, request, scheme); } catch (IllegalArgumentException e) { LOGGER.log(Level.WARN, "Failure Decoding Request", e); respond(ctx, request, HttpResponseStatus.BAD_REQUEST); @@ -174,6 +174,11 @@ public class HttpServerHandler<T extends HttpServer> extends SimpleChannelInboun response -> response.headers().set(HttpUtil.PERMANENT, "true")); } + protected IServletRequest createServletRequest(ChannelHandlerContext ctx, FullHttpRequest request, + HttpScheme scheme) { + return HttpUtil.toServletRequest(ctx, request, scheme); + } + @Override public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { LOGGER.log(Level.WARN, "Failure handling HTTP Request", cause);
