This is an automated email from the ASF dual-hosted git repository.
htowaileb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 8cd86de37c Add overridable clean up step after dropping a dataverse
new ab5d9a5b4d Merge branch 'gerrit/neo'
8cd86de37c is described below
commit 8cd86de37c453dd9b9212c464ad7176f82dc87a4
Author: Hussain Towaileb <[email protected]>
AuthorDate: Thu Jul 14 19:03:40 2022 +0300
Add overridable clean up step after dropping a dataverse
Change-Id: Ic0e4997f22e3c24dc0a3fafe5a44ef8a960a6dff
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16943
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Hussain Towaileb <[email protected]>
Reviewed-by: Michael Blow <[email protected]>
---
.../java/org/apache/asterix/app/translator/QueryTranslator.java | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 41d92822a5..1729b5037d 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -2035,6 +2035,8 @@ public class QueryTranslator extends
AbstractLangTranslator implements IStatemen
if (activeDataverse.getDataverseName().equals(dataverseName)) {
activeDataverse = MetadataBuiltinEntities.DEFAULT_DATAVERSE;
}
+
+ validateDataverseDatasetsStateAfterDrop(metadataProvider,
mdTxnCtx, datasets);
MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
return true;
} catch (Exception e) {
@@ -2081,7 +2083,12 @@ public class QueryTranslator extends
AbstractLangTranslator implements IStatemen
protected void validateDataverseStateBeforeDrop(MetadataProvider
metadataProvider, Dataverse dataverse,
SourceLocation sourceLoc) throws AlgebricksException {
- // may be overriden by product extensions for additional checks before
dropping the dataverse
+ // may be overridden by product extensions for additional checks
before dropping the dataverse
+ }
+
+ protected void validateDataverseDatasetsStateAfterDrop(MetadataProvider
metadataProvider,
+ MetadataTransactionContext mdTxnCtx, List<Dataset> datasets)
throws AlgebricksException {
+ // may be overridden by product extensions for additional checks after
dropping the dataverse
}
public void handleDatasetDropStatement(MetadataProvider metadataProvider,
Statement stmt,
