This is an automated email from the ASF dual-hosted git repository. mhubail pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push: new 41fae6a4ec [NO-ISSUE][MTD] Incorrect deserailization of dataset primary key types 41fae6a4ec is described below commit 41fae6a4ec144d7e74556e3c768ddcbf73b70976 Author: Peeyush Gupta <peeyush.gu...@couchbase.com> AuthorDate: Mon May 15 11:39:25 2023 -0700 [NO-ISSUE][MTD] Incorrect deserailization of dataset primary key types - user model changes: no - storage format changes: no - interface changes: no Details: While deserializing dataset details, all primary key types were incorrectly set to string. Change-Id: I20636cb8535709f607e8748e1fdd9383ab269cf7 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17532 Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Tested-by: Murtadha Hubail <mhub...@apache.org> Reviewed-by: Murtadha Hubail <mhub...@apache.org> --- .../metadata/entitytupletranslators/DatasetTupleTranslator.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java index e659b8fe21..70dfde1acc 100644 --- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java +++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java @@ -149,7 +149,6 @@ public class DatasetTupleTranslator extends AbstractTupleTranslator<Dataset> { .getValueByPos(MetadataRecordTypes.INTERNAL_DETAILS_ARECORD_PARTITIONKEY_FIELD_INDEX)) .getCursor(); List<List<String>> partitioningKey = new ArrayList<>(); - List<IAType> partitioningKeyType = new ArrayList<>(); while (cursor.next()) { AOrderedList fieldNameList = (AOrderedList) cursor.get(); @@ -159,7 +158,6 @@ public class DatasetTupleTranslator extends AbstractTupleTranslator<Dataset> { nestedFieldName.add(((AString) nestedFieldNameCursor.get()).getStringValue()); } partitioningKey.add(nestedFieldName); - partitioningKeyType.add(BuiltinType.ASTRING); } // Check if there is a primary key types field @@ -223,7 +221,7 @@ public class DatasetTupleTranslator extends AbstractTupleTranslator<Dataset> { } datasetDetails = new InternalDatasetDetails(fileStructure, partitioningStrategy, partitioningKey, - partitioningKey, keyFieldSourceIndicator, partitioningKeyType, autogenerated, + partitioningKey, keyFieldSourceIndicator, primaryKeyTypes, autogenerated, filterSourceIndicator, filterField); break; }