This is an automated email from the ASF dual-hosted git repository.
mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 51b0283d95 [NO ISSUE][CLUS] no replica failure messages on disabled
replication
51b0283d95 is described below
commit 51b0283d9575f670ca00aa359610f54b2a25e93c
Author: Murtadha Hubail <[email protected]>
AuthorDate: Mon Oct 30 15:42:13 2023 +0300
[NO ISSUE][CLUS] no replica failure messages on disabled replication
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Do not send replica failure messages to NCs on node failures
when replication is disabled.
Change-Id: Ided98c584f9ba7ed81683005da86da5eab4da5d1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17887
Integration-Tests: Jenkins <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
Reviewed-by: Ali Alsuliman <[email protected]>
Tested-by: Jenkins <[email protected]>
---
.../org/apache/asterix/app/replication/NcLifecycleCoordinator.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 4135f356b3..dde2371d31 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -332,6 +332,9 @@ public class NcLifecycleCoordinator implements
INcLifecycleCoordinator {
private void notifyFailedReplica(IClusterStateManager clusterManager,
String nodeID,
InetSocketAddress replicaAddress) {
+ if (!replicationEnabled) {
+ return;
+ }
LOGGER.info("notify replica failure of nodeId {} at {}", nodeID,
replicaAddress);
Set<String> ncs = clusterManager.getParticipantNodes(true);
ReplicaFailedMessage message =
