This is an automated email from the ASF dual-hosted git repository.

alsuliman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit cc1334aa58aa7debccf6f0d83629a4e4baaed895
Author: Michael Blow <[email protected]>
AuthorDate: Mon May 6 22:27:08 2024 -0400

    [NO ISSUE][HYR] Reduce config manager debug logging
    
    Change-Id: I40d385e6cf5260b7e9e4c414c6279746b419405f
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18269
    Reviewed-by: Michael Blow <[email protected]>
    Reviewed-by: Ali Alsuliman <[email protected]>
    Tested-by: Michael Blow <[email protected]>
    Contrib: Michael Blow <[email protected]>
---
 .../apache/hyracks/control/common/config/ConfigManager.java   | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
index 85661fe800..9c5a9fa144 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
@@ -148,7 +148,7 @@ public class ConfigManager implements IConfigManager, 
Serializable {
             if (configured) {
                 throw new IllegalStateException("configuration already 
processed");
             }
-            LOGGER.debug("registering option: " + option.toIniString());
+            LOGGER.trace("registering option: {}", option::toIniString);
             Map<String, IOption> optionMap = 
sectionMap.computeIfAbsent(option.section(), section -> new HashMap<>());
             IOption prev = optionMap.put(option.ini(), option);
             if (prev != null) {
@@ -160,8 +160,13 @@ public class ConfigManager implements IConfigManager, 
Serializable {
                 registeredOptions.add(option);
                 optionSetters.put(option, (node, value, isDefault) -> 
correctedMap(node, isDefault).put(option, value));
                 if (LOGGER.isDebugEnabled()) {
-                    optionSetters.put(option, (node, value, isDefault) -> 
LOGGER.debug("{} {} to {} for node {}",
-                            isDefault ? "defaulting" : "setting", 
option.toIniString(), value, node));
+                    optionSetters.put(option, (node, value, isDefault) -> {
+                        if (isDefault) {
+                            LOGGER.trace("defaulting {} to {} for node {}", 
option.toIniString(), value, node);
+                        } else {
+                            LOGGER.debug("setting {} to {} for node {}", 
option.toIniString(), value, node);
+                        }
+                    });
                 }
             }
         }

Reply via email to