This is an automated email from the ASF dual-hosted git repository.
alsuliman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 65f97ea0c2 [NO ISSUE][OTH] Add logs when failure to
activate/deactivate index
65f97ea0c2 is described below
commit 65f97ea0c269ecea8a35ac70c0f03ca1a3aa127b
Author: Ali Alsuliman <[email protected]>
AuthorDate: Thu May 23 23:11:15 2024 +0300
[NO ISSUE][OTH] Add logs when failure to activate/deactivate index
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Change-Id: I0cdfbbeafd4ec7d06798bb1a9352416eca76dfff
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18315
Reviewed-by: Murtadha Hubail <[email protected]>
Tested-by: Ali Alsuliman <[email protected]>
---
.../apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java | 5 ++---
.../apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java | 5 +++++
.../apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java | 5 +++++
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
index a2cdda8763..eb125f3d27 100644
---
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
+++
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
@@ -18,9 +18,6 @@
*/
package org.apache.asterix.cloud.lazy.filesystem;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
-
import java.io.IOException;
import java.nio.ByteBuffer;
@@ -32,6 +29,8 @@ import org.apache.asterix.common.config.CloudProperties;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.IFileHandle;
import org.apache.hyracks.cloud.filesystem.FileSystemOperationDispatcherUtil;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public final class HolePuncherProvider {
private static final Logger LOGGER = LogManager.getLogger();
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
index 9f6ce7883b..3a0f2b9d6c 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
@@ -72,6 +72,7 @@ public abstract class AbstractTreeIndex implements ITreeIndex
{
@Override
public synchronized void create() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot create already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_CREATE_ACTIVE_INDEX);
}
fileId = bufferCache.createFile(file);
@@ -107,6 +108,7 @@ public abstract class AbstractTreeIndex implements
ITreeIndex {
@Override
public synchronized void activate() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot activate already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_ACTIVATE_ACTIVE_INDEX);
}
if (fileId >= 0) {
@@ -135,6 +137,7 @@ public abstract class AbstractTreeIndex implements
ITreeIndex {
@Override
public void purge() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot purge already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_PURGE_ACTIVE_INDEX);
}
bufferCache.purgeHandle(fileId);
@@ -145,6 +148,7 @@ public abstract class AbstractTreeIndex implements
ITreeIndex {
@Override
public synchronized void destroy() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot destroy already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_DESTROY_ACTIVE_INDEX);
}
bufferCache.deleteFile(file);
@@ -153,6 +157,7 @@ public abstract class AbstractTreeIndex implements
ITreeIndex {
@Override
public synchronized void clear() throws HyracksDataException {
if (!isActive) {
+ LOGGER.warn("Cannot clear already inactive index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_CLEAR_INACTIVE_INDEX);
}
freePageManager.init(interiorFrameFactory, leafFrameFactory);
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
index 05347541dc..3656e4fb22 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
@@ -184,6 +184,7 @@ public abstract class AbstractLSMIndex implements ILSMIndex
{
@Override
public synchronized void create() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot create already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_CREATE_ACTIVE_INDEX);
}
fileManager.createDirs();
@@ -193,6 +194,7 @@ public abstract class AbstractLSMIndex implements ILSMIndex
{
@Override
public synchronized void activate() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot activate already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_ACTIVATE_ACTIVE_INDEX);
}
loadDiskComponents();
@@ -270,6 +272,7 @@ public abstract class AbstractLSMIndex implements ILSMIndex
{
@Override
public synchronized void destroy() throws HyracksDataException {
if (isActive) {
+ LOGGER.warn("Cannot destroy already active index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_DESTROY_ACTIVE_INDEX);
}
destroyDiskComponents();
@@ -288,6 +291,7 @@ public abstract class AbstractLSMIndex implements ILSMIndex
{
@Override
public synchronized void clear() throws HyracksDataException {
if (!isActive) {
+ LOGGER.warn("Cannot clear already inactive index {}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_CLEAR_INACTIVE_INDEX);
}
resetMemoryComponents();
@@ -573,6 +577,7 @@ public abstract class AbstractLSMIndex implements ILSMIndex
{
@Override
public synchronized void allocateMemoryComponents() throws
HyracksDataException {
if (!isActive) {
+ LOGGER.warn("Cannot allocate memory for already inactive index
{}", this);
throw
HyracksDataException.create(ErrorCode.CANNOT_ALLOCATE_MEMORY_FOR_INACTIVE_INDEX);
}
if (memoryComponentsAllocated || memoryComponents == null) {
