This is an automated email from the ASF dual-hosted git repository.
wyk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 7b3f1eb481 [NO ISSUE][OTH] Reduce disk cache log verbosity
7b3f1eb481 is described below
commit 7b3f1eb481a54119529d1372df148468613dd69e
Author: Wail Alkowaileet <[email protected]>
AuthorDate: Thu May 23 14:05:45 2024 -0700
[NO ISSUE][OTH] Reduce disk cache log verbosity
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Move to disk pressure log to debug if no presure
- Increase disk cache monitoring interval to 120s
Change-Id: Ib5f77323c3c8af932175c0c42446d6d959b07030
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18313
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
---
.../results/api/cluster_state_1/cluster_state_1.1.regexadm | 2 +-
.../api/cluster_state_1_full/cluster_state_1_full.1.regexadm | 2 +-
.../api/cluster_state_1_less/cluster_state_1_less.1.regexadm | 2 +-
.../org/apache/asterix/common/config/CloudProperties.java | 4 ++--
.../org/apache/hyracks/cloud/filesystem/PhysicalDrive.java | 11 +++++++++--
5 files changed, 14 insertions(+), 7 deletions(-)
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
index b8ddc87ce9..57a14bda87 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
@@ -17,7 +17,7 @@
"cloud.storage.cache.policy" : "selective",
"cloud.storage.debug.mode.enabled" : false,
"cloud.storage.debug.sweep.threshold.size" : 1073741824,
- "cloud.storage.disk.monitor.interval" : 60,
+ "cloud.storage.disk.monitor.interval" : 120,
"cloud.storage.endpoint" : "",
"cloud.storage.index.inactive.duration.threshold" : 360,
"cloud.storage.prefix" : "",
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
index 3d92c44a60..09492ba143 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
@@ -17,7 +17,7 @@
"cloud.storage.cache.policy" : "selective",
"cloud.storage.debug.mode.enabled" : false,
"cloud.storage.debug.sweep.threshold.size" : 1073741824,
- "cloud.storage.disk.monitor.interval" : 60,
+ "cloud.storage.disk.monitor.interval" : 120,
"cloud.storage.endpoint" : "",
"cloud.storage.index.inactive.duration.threshold" : 360,
"cloud.storage.prefix" : "",
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
index 5264d9d7ef..58fc0dcaaf 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
@@ -17,7 +17,7 @@
"cloud.storage.cache.policy" : "selective",
"cloud.storage.debug.mode.enabled" : false,
"cloud.storage.debug.sweep.threshold.size" : 1073741824,
- "cloud.storage.disk.monitor.interval" : 60,
+ "cloud.storage.disk.monitor.interval" : 120,
"cloud.storage.endpoint" : "",
"cloud.storage.index.inactive.duration.threshold" : 360,
"cloud.storage.prefix" : "",
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
index dd90f1a17b..ea12621cce 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
@@ -52,7 +52,7 @@ public class CloudProperties extends AbstractProperties {
CLOUD_STORAGE_ALLOCATION_PERCENTAGE(DOUBLE, 0.8d),
// 90% of the allocated space for storage (i.e., 90% of the 80% of the
total disk space)
CLOUD_STORAGE_SWEEP_THRESHOLD_PERCENTAGE(DOUBLE, 0.9d),
- CLOUD_STORAGE_DISK_MONITOR_INTERVAL(POSITIVE_INTEGER, 60),
+ CLOUD_STORAGE_DISK_MONITOR_INTERVAL(POSITIVE_INTEGER, 120),
CLOUD_STORAGE_INDEX_INACTIVE_DURATION_THRESHOLD(POSITIVE_INTEGER, 360),
CLOUD_STORAGE_DEBUG_MODE_ENABLED(BOOLEAN, false),
CLOUD_STORAGE_DEBUG_SWEEP_THRESHOLD_SIZE(LONG_BYTE_UNIT,
StorageUtil.getLongSizeInBytes(1, GIGABYTE)),
@@ -124,7 +124,7 @@ public class CloudProperties extends AbstractProperties {
case CLOUD_STORAGE_DISK_MONITOR_INTERVAL:
return "The disk monitoring interval time (in seconds):
determines how often the system"
+ " checks for pressure on disk space when using
the 'selective' caching policy."
- + " (default : 60 seconds)";
+ + " (default : 120 seconds)";
case CLOUD_STORAGE_INDEX_INACTIVE_DURATION_THRESHOLD:
return "The duration in minutes to consider an index is
inactive. (default: 360 or 6 hours)";
case CLOUD_STORAGE_DEBUG_MODE_ENABLED:
diff --git
a/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
b/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
index 6a2d9c8740..e4fefa55bb 100644
---
a/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
+++
b/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
@@ -56,8 +56,15 @@ public final class PhysicalDrive implements IPhysicalDrive {
long usedSpace = getUsedSpace();
boolean isPressured = usedSpace > pressureSize;
pressured.set(isPressured);
- LOGGER.info("Used space: {}, pressureCapacity: {} (isPressured: {})",
- StorageUtil.toHumanReadableSize(usedSpace),
StorageUtil.toHumanReadableSize(pressureSize), isPressured);
+
+ if (isPressured) {
+ LOGGER.info("Used space: {}, pressureCapacity: {} (isPressured:
{})",
+ StorageUtil.toHumanReadableSize(usedSpace),
StorageUtil.toHumanReadableSize(pressureSize), true);
+ } else {
+ LOGGER.debug("Used space: {}, pressureCapacity: {} (isPressured:
{})",
+ StorageUtil.toHumanReadableSize(usedSpace),
StorageUtil.toHumanReadableSize(pressureSize), false);
+ }
+
return isPressured;
}
