This is an automated email from the ASF dual-hosted git repository.
wyk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
The following commit(s) were added to refs/heads/master by this push:
new 505dde994d [ASTERIXDB-3406][TX] Atomic insert/upsert hang in
GlobalTxManager
505dde994d is described below
commit 505dde994d9991285d0c9c468a2f65854f8a61b3
Author: Peeyush Gupta <[email protected]>
AuthorDate: Wed May 29 18:18:49 2024 -0700
[ASTERIXDB-3406][TX] Atomic insert/upsert hang in GlobalTxManager
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Atomic Insert/Upsert where stuck indefinitely in case a
job is finished at one of the nodes even before the notifyJobStart
is called.
Change-Id: Idb6468103310cef2d053e5304582b40274f520f2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18330
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Peeyush Gupta <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
---
.../src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
index c85e3b0ef4..a5c9867c6c 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
@@ -226,11 +226,6 @@ public class GlobalTxManager implements IGlobalTxManager {
@Override
public void notifyJobCreation(JobId jobId, JobSpecification spec,
IJobCapacityController.JobSubmissionStatus status)
throws HyracksException {
-
- }
-
- @Override
- public void notifyJobStart(JobId jobId, JobSpecification spec) throws
HyracksException {
GlobalTxInfo globalTxInfo = (GlobalTxInfo)
spec.getProperty(GlOBAL_TX_PROPERTY_NAME);
if (globalTxInfo != null) {
beginTransaction(jobId, globalTxInfo.getNumNodes(),
globalTxInfo.getNumPartitions(),
@@ -238,6 +233,10 @@ public class GlobalTxManager implements IGlobalTxManager {
}
}
+ @Override
+ public void notifyJobStart(JobId jobId, JobSpecification spec) throws
HyracksException {
+ }
+
@Override
public void notifyJobFinish(JobId jobId, JobSpecification spec, JobStatus
jobStatus, List<Exception> exceptions)
throws HyracksException {
