This is an automated email from the ASF dual-hosted git repository.

mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new a62c9742be [ASTERIXDB-3456][EXT] Allow S3 endpoint to be null
a62c9742be is described below

commit a62c9742be33e411b8b4ee3d6155e0722fbada4c
Author: Murtadha Hubail <[email protected]>
AuthorDate: Fri Jul 12 04:07:20 2024 +0300

    [ASTERIXDB-3456][EXT] Allow S3 endpoint to be null
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    
    - Endpoint is optional and can be null for S3 clients.
    
    Ext-ref: MB-62688
    Change-Id: I78c2d2dd5da166b32e86c74fe38d66a97d321852
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18467
    Reviewed-by: Michael Blow <[email protected]>
    Integration-Tests: Jenkins <[email protected]>
    Tested-by: Michael Blow <[email protected]>
---
 .../java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
 
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
index 37872dda5f..fe73a0add2 100644
--- 
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
+++ 
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
@@ -42,7 +42,7 @@ public final class S3ClientConfig {
     public S3ClientConfig(String region, String endpoint, String prefix, 
boolean anonymousAuth,
             long profilerLogInterval, int writeBufferSize) {
         this.region = Objects.requireNonNull(region, "region");
-        this.endpoint = Objects.requireNonNull(endpoint, "endpoint");
+        this.endpoint = endpoint;
         this.prefix = Objects.requireNonNull(prefix, "prefix");
         this.anonymousAuth = anonymousAuth;
         this.profilerLogInterval = profilerLogInterval;

Reply via email to