This is an automated email from the ASF dual-hosted git repository. mblow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit a3e0fd491dbb9fdb8ad0ee3d2a681267815702d2 Author: Wail Alkowaileet <[email protected]> AuthorDate: Tue Aug 6 17:34:48 2024 +0300 [ASTERIXDB-3469][OTH] Use AUUID length instead of 16 - user model changes: no - storage format changes: no - interface changes: no Details: Use AUUID.UUID_BYTES to get the length of UUID bytes. Ext-ref: MB-62909 Change-Id: I5c0b99c8810e2abd551978a3e0a36bbf2ad874b7 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18625 Reviewed-by: Wail Alkowaileet <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Integration-Tests: Jenkins <[email protected]> Tested-by: Wail Alkowaileet <[email protected]> --- .../org/apache/asterix/column/assembler/value/UUIDValueGetter.java | 5 +++-- .../apache/asterix/column/values/reader/value/UUIDValueReader.java | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/value/UUIDValueGetter.java b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/value/UUIDValueGetter.java index 135ed8571b..408ccbbe8d 100644 --- a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/value/UUIDValueGetter.java +++ b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/value/UUIDValueGetter.java @@ -19,12 +19,13 @@ package org.apache.asterix.column.assembler.value; import org.apache.asterix.column.values.IColumnValuesReader; +import org.apache.asterix.om.base.AUUID; import org.apache.asterix.om.types.ATypeTag; import org.apache.hyracks.data.std.api.IValueReference; class UUIDValueGetter extends AbstractFixedLengthValueGetter { UUIDValueGetter() { - super(ATypeTag.UUID, 16); + super(ATypeTag.UUID, AUUID.UUID_BYTES); } @Override @@ -34,4 +35,4 @@ class UUIDValueGetter extends AbstractFixedLengthValueGetter { uuid.getLength()); return value; } -} \ No newline at end of file +} diff --git a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/UUIDValueReader.java b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/UUIDValueReader.java index 741d9b39d8..a029d6fa86 100644 --- a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/UUIDValueReader.java +++ b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/value/UUIDValueReader.java @@ -23,6 +23,7 @@ import java.io.IOException; import org.apache.asterix.column.bytes.decoder.ParquetPlainFixedLengthValuesReader; import org.apache.asterix.column.bytes.stream.in.AbstractBytesInputStream; import org.apache.asterix.dataflow.data.nontagged.comparators.AUUIDPartialBinaryComparatorFactory; +import org.apache.asterix.om.base.AUUID; import org.apache.asterix.om.types.ATypeTag; import org.apache.hyracks.data.std.api.IValueReference; import org.apache.hyracks.data.std.util.ArrayBackedValueStorage; @@ -32,8 +33,8 @@ public final class UUIDValueReader extends AbstractValueReader { private IValueReference nextValue; public UUIDValueReader() { - ArrayBackedValueStorage storage = new ArrayBackedValueStorage(16); - storage.setSize(16); + ArrayBackedValueStorage storage = new ArrayBackedValueStorage(AUUID.UUID_BYTES); + storage.setSize(AUUID.UUID_BYTES); uuidReader = new ParquetPlainFixedLengthValuesReader(storage); }
