(asterixdb) branch master updated: [ASTERIXDB-3560][COMP] Routine was switched to void as return value not needed

[vsarathy1]

This is an automated email from the ASF dual-hosted git repository.

vsarathy1 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 064cbb5483 [ASTERIXDB-3560][COMP] Routine was switched to void as 
return value not needed
064cbb5483 is described below

commit 064cbb548370f06cecd2dcf7eea01735e468d4e3
Author: murali4104 <murali.kris...@couchbase.com>
AuthorDate: Tue Feb 4 15:31:44 2025 -0800

    [ASTERIXDB-3560][COMP] Routine was switched to void as return value not 
needed
    
    Change-Id: Idfd718b4d60f848d9345d85ba3bfd513cd2ea3a5
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19385
    Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
    Reviewed-by: <murali.kris...@couchbase.com>
    Reviewed-by: Vijay Sarathy <vijay.sara...@couchbase.com>
    Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
---
 .../apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java    | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
index 1dc37c4c95..0861c019a0 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
@@ -970,7 +970,7 @@ public class EnumerateJoinsRule implements 
IAlgebraicRewriteRule {
     }
 
     // Each outer join will create one set of dependencies. The right side 
depends on the left side.
-    private boolean buildDependencyList(ILogicalOperator op, JoinOperator jO,
+    private void buildDependencyList(ILogicalOperator op, JoinOperator jO,
             List<Quadruple<Integer, Integer, JoinOperator, Integer>> 
outerJoinsDependencyList, int rightSideBits)
             throws AlgebricksException {
         AbstractBinaryJoinOperator outerJoinOp = (AbstractBinaryJoinOperator) 
op;
@@ -1018,7 +1018,6 @@ public class EnumerateJoinsRule implements 
IAlgebraicRewriteRule {
                 outerJoinsDependencyList.add(new Quadruple(leftSideExprBits, 
rightSideBits, jO, 0));
             }
         }
-        return true;
     }
 
     private ILogicalExpression joinExprFound(ILogicalOperator op) {
@@ -1073,10 +1072,7 @@ public class EnumerateJoinsRule implements 
IAlgebraicRewriteRule {
                             && (firstLeafInputNumber < lastLeafInputNumber)) { 
// if more is than one leafInput, only then buildSets make sense.
                         buildSets.add(new Triple<>(k, lastLeafInputNumber - 
firstLeafInputNumber + 1, true)); // convert the second to boolean later
                     }
-                    boolean ret = buildDependencyList(op, jO, 
outerJoinsDependencyList, k);
-                    if (!ret) {
-                        return false;
-                    }
+                    buildDependencyList(op, jO, outerJoinsDependencyList, k);
                 }
             }
         } else {