This is an automated email from the ASF dual-hosted git repository.
mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit 8294353ea06b1bfa5775d7543b78dd2644718d1f
Merge: 2f34b31175 d23cc23ddc
Author: Ali Alsuliman <ali.al.solai...@gmail.com>
AuthorDate: Mon Aug 11 15:30:05 2025 -0700
Merge branch 'gerrit/trinity' into 'gerrit/ionic'
* [NO ISSUE][OTH] Extend create/drop view/synonym calls with the request
parameters
Ext-ref: MB-55519
Change-Id: I10e0da93dd001608a572665451a1ef8ac7b98f57
.../org/apache/asterix/app/translator/QueryTranslator.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --cc
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index c8af10e137,dede4bea9c..f921ff023d
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@@ -3999,20 -3570,18 +3999,20 @@@ public class QueryTranslator extends Ab
if (isCompileOnly()) {
return;
}
- lockUtil.createSynonymBegin(lockManager, metadataProvider.getLocks(),
dataverseName, synonymName);
+ lockUtil.createSynonymBegin(lockManager, metadataProvider.getLocks(),
databaseName, dataverseName, synonymName);
try {
- doCreateSynonym(metadataProvider, css, dataverseName,
synonymName, objectDataverseName, objectName,
- requestParameters, true);
+ doCreateSynonym(metadataProvider, css, stmtActiveNamespace,
synonymName, objectNamespace, objectName,
- creator);
++ creator, requestParameters, true);
} finally {
metadataProvider.getLocks().unlock();
}
}
protected CreateResult doCreateSynonym(MetadataProvider metadataProvider,
CreateSynonymStatement css,
- Namespace namespace, String synonymName, Namespace
objectNamespace, String objectName, Creator creator)
- throws Exception {
- DataverseName dataverseName, String synonymName, DataverseName
objectDataverseName, String objectName,
++ Namespace namespace, String synonymName, Namespace
objectNamespace, String objectName, Creator creator,
+ IRequestParameters requestParameters, boolean
viaCreateSynonymStatement) throws Exception {
+ String databaseName = namespace.getDatabaseName();
+ DataverseName dataverseName = namespace.getDataverseName();
MetadataTransactionContext mdTxnCtx =
MetadataManager.INSTANCE.beginTransaction();
metadataProvider.setMetadataTxnContext(mdTxnCtx);
try {
@@@ -4059,16 -3622,17 +4059,18 @@@
if (isCompileOnly()) {
return;
}
- lockUtil.dropSynonymBegin(lockManager, metadataProvider.getLocks(),
dataverseName, synonymName);
+ lockUtil.dropSynonymBegin(lockManager, metadataProvider.getLocks(),
databaseName, dataverseName, synonymName);
try {
- doDropSynonym(metadataProvider, stmtSynDrop, databaseName,
dataverseName, synonymName);
- doDropSynonym(metadataProvider, stmtSynDrop, dataverseName,
synonymName, requestParameters, true);
++ doDropSynonym(metadataProvider, stmtSynDrop, databaseName,
dataverseName, synonymName, requestParameters,
++ true);
} finally {
metadataProvider.getLocks().unlock();
}
}
protected boolean doDropSynonym(MetadataProvider metadataProvider,
SynonymDropStatement stmtSynDrop,
- String databaseName, DataverseName dataverseName, String
synonymName) throws Exception {
- DataverseName dataverseName, String synonymName,
IRequestParameters requestParameters,
++ String databaseName, DataverseName dataverseName, String
synonymName, IRequestParameters requestParameters,
+ boolean viaDropSynonymStatement) throws Exception {
MetadataTransactionContext mdTxnCtx =
MetadataManager.INSTANCE.beginTransaction();
metadataProvider.setMetadataTxnContext(mdTxnCtx);
try {
