This is an automated email from the ASF dual-hosted git repository.

kbhatt pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/atlas.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new 2e7fbb8  ATLAS-3138 UI : Stats popup table layout improve for better 
readability -- adding missing number format for entities list
2e7fbb8 is described below

commit 2e7fbb8fe59e989a1ad406c0efb008b6c74d639b
Author: gutkaBinit <binitgu...@gmail.com>
AuthorDate: Tue Apr 16 12:35:44 2019 +0530

    ATLAS-3138 UI : Stats popup table layout improve for better readability -- 
adding missing number format for entities list
    
    (cherry picked from commit 93e629fa839f30f2641b284c874485fbe3505b27)
    Signed-off-by: kevalbhatt <kbh...@apache.org>
---
 dashboardv2/public/js/views/site/Statistics.js | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/dashboardv2/public/js/views/site/Statistics.js 
b/dashboardv2/public/js/views/site/Statistics.js
index 6f402cf..1bf4859 100644
--- a/dashboardv2/public/js/views/site/Statistics.js
+++ b/dashboardv2/public/js/views/site/Statistics.js
@@ -117,20 +117,20 @@ define(['require',
                             type = opt.type;
                         _.each(entityData, function(val, key) {
                             var intVal = _.isUndefined(val) ? 0 : val;
+                            if (type == "active") {
+                                activeEntityCount += intVal;
+                            } else {
+                                deletedEntityCount += intVal;
+                            }
+                            intVal = _.numberFormatWithComa(intVal)
                             if (stats[key]) {
                                 stats[key][type] = intVal;
                             } else {
                                 stats[key] = {};
                                 stats[key][type] = intVal;
                             }
-                            if (type == "active") {
-                                activeEntityCount += intVal;
-                            } else {
-                                deletedEntityCount += intVal;
-                            }
                         })
                     };
-
                 createEntityData({
                     "entityData": activeEntities,
                     "type": "active"
@@ -167,8 +167,7 @@ define(['require',
                         return tableBody;
                     };
                 if (data.Notification) {
-                    var tableCol = [
-                            {
+                    var tableCol = [{
                                 label: "Total <br> (from " + (that.getValue({
                                     "value": data.Server["startTimeStamp"],
                                     "type": 
Enums.stats.Server["startTimeStamp"],
@@ -254,4 +253,4 @@ define(['require',
             }
         });
     return StatisticsView;
-});
+});
\ No newline at end of file

Reply via email to