This is an automated email from the ASF dual-hosted git repository.

kbhatt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/atlas.git


The following commit(s) were added to refs/heads/master by this push:
     new 250c2ea  ATLAS-3925: UI: Properties with value 0 or false are 
displayed as N/A for
250c2ea is described below

commit 250c2eaf249fd115f71b11019bfc4b153810bde8
Author: kevalbhatt <[email protected]>
AuthorDate: Wed Aug 26 15:40:01 2020 +0530

    ATLAS-3925: UI: Properties with value 0 or false are displayed as N/A for
---
 dashboardv2/public/js/utils/CommonViewFunction.js | 3 +--
 dashboardv3/public/js/utils/CommonViewFunction.js | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dashboardv2/public/js/utils/CommonViewFunction.js 
b/dashboardv2/public/js/utils/CommonViewFunction.js
index 4d10fa6..23a40df 100644
--- a/dashboardv2/public/js/utils/CommonViewFunction.js
+++ b/dashboardv2/public/js/utils/CommonViewFunction.js
@@ -102,7 +102,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 
'utils/Messages', 'utils/Enum
                 }
             },
             getValue = function(val) {
-                if (val) {
+                if (!_.isUndefined(val)) {
                     if ((_.isNumber(val) || !_.isNaN(parseInt(val))) && 
formatIntVal) {
                         return numberFormat(val);
                     } else {
@@ -612,7 +612,6 @@ define(['require', 'utils/Utils', 'modules/Modal', 
'utils/Messages', 'utils/Enum
                                 rule = {};
                             if (apiObj) {
                                 rule = { attributeName: temp[0], operator: 
mapUiOperatorToAPI(temp[1]), attributeValue: _.trim(temp[2]) }
-
                                 rule.attributeValue = rule.type === 'date' && 
formatDate && rule.attributeValue.length ? 
moment(parseInt(rule.attributeValue)).format(Globals.dateTimeFormat) : 
rule.attributeValue;
                             } else {
                                 rule = { id: temp[0], operator: temp[1], 
value: _.trim(temp[2]) }
diff --git a/dashboardv3/public/js/utils/CommonViewFunction.js 
b/dashboardv3/public/js/utils/CommonViewFunction.js
index 670e509..c4e11a6 100644
--- a/dashboardv3/public/js/utils/CommonViewFunction.js
+++ b/dashboardv3/public/js/utils/CommonViewFunction.js
@@ -102,7 +102,7 @@ define(['require', 'utils/Utils', 'modules/Modal', 
'utils/Messages', 'utils/Enum
                 }
             },
             getValue = function(val) {
-                if (val) {
+                if (!_.isUndefined(val)) {
                     if ((_.isNumber(val) || !_.isNaN(parseInt(val))) && 
formatIntVal) {
                         return numberFormat(val);
                     } else {

Reply via email to