This is an automated email from the ASF dual-hosted git repository.
nixon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/master by this push:
new 4be86b5 ATLAS-4229: UI[DSL-Advanced search] If the search query does
not match any results, then Atlas UI keep loading forever.
4be86b5 is described below
commit 4be86b58732ede51c6e0228a4ee102f7283d9652
Author: prasad pawar <[email protected]>
AuthorDate: Tue Mar 30 19:05:11 2021 +0530
ATLAS-4229: UI[DSL-Advanced search] If the search query does not match any
results, then Atlas UI keep loading forever.
Signed-off-by: nixonrodrigues <[email protected]>
---
dashboardv2/public/js/views/search/SearchResultLayoutView.js | 2 +-
dashboardv3/public/js/views/search/SearchResultLayoutView.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dashboardv2/public/js/views/search/SearchResultLayoutView.js
b/dashboardv2/public/js/views/search/SearchResultLayoutView.js
index 98c9ec0..74dc58d 100644
--- a/dashboardv2/public/js/views/search/SearchResultLayoutView.js
+++ b/dashboardv2/public/js/views/search/SearchResultLayoutView.js
@@ -568,7 +568,7 @@ define(['require',
});
var columns = new
columnCollection((that.searchCollection.dynamicTable ?
that.getDaynamicColumns(that.searchCollection.toJSON()) :
that.getFixedDslColumn()));
columns.setPositions().sort();
- if (this.searchType == "Advanced Search" && columns.length) {
+ if (this.searchType == "Advanced Search" && columns.length &&
that.searchCollection.length) {
//for dsl search with Select clause, default column to be
use as sorting
var tableColumnNames =
Object.keys(that.searchCollection.toJSON()[0]);
that.commonTableOptions['sortOpts'] = {
diff --git a/dashboardv3/public/js/views/search/SearchResultLayoutView.js
b/dashboardv3/public/js/views/search/SearchResultLayoutView.js
index d5883ca..26bd969 100644
--- a/dashboardv3/public/js/views/search/SearchResultLayoutView.js
+++ b/dashboardv3/public/js/views/search/SearchResultLayoutView.js
@@ -584,7 +584,7 @@ define(['require',
});
var columns = new
columnCollection((that.searchCollection.dynamicTable ?
that.getDaynamicColumns(that.searchCollection.toJSON()) :
that.getFixedDslColumn()));
columns.setPositions().sort();
- if (this.searchType == "Advanced Search" && columns.length) {
+ if (this.searchType == "Advanced Search" && columns.length &&
that.searchCollection.length) {
//for dsl search with Select clause, default column to be
use as sorting
var tableColumnNames =
Object.keys(that.searchCollection.toJSON()[0]);
that.commonTableOptions['sortOpts'] = {
