This is an automated email from the ASF dual-hosted git repository.
pinal pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new c7496ffcd ATLAS-4660 : (UI)Deleting businesss metadata attribute
values with spaces in their key names results in unexpected behaviour
c7496ffcd is described below
commit c7496ffcd8122fa0f5ecd47f962b7b71fd7f3c52
Author: Farhan Khan <[email protected]>
AuthorDate: Wed Aug 24 13:21:01 2022 +0530
ATLAS-4660 : (UI)Deleting businesss metadata attribute values with spaces
in their key names results in unexpected behaviour
Signed-off-by: Pinal Shah <[email protected]>
(cherry picked from commit 18aa87c0cffbe8e32483f8b88aae0cd9a11d2476)
---
dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js | 2 +-
dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
index ad5e28e94..3169c7b3d 100644
--- a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
+++ b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js
@@ -387,7 +387,7 @@ define(['require',
trs = "";
_.each(this.model.attributes, function(val, key) {
if (key !== "__internal_UI_businessMetadataName" && key !==
"isNew") {
- var td = '<td class="custom-col-1" data-key=' + key + '>'
+ key + ' (' + _.escape(val.typeName) + ')</td><td
class="custom-col-0">:</td><td class="custom-col-1" data-id="value">' +
that.getAttrElement({ businessMetadata:
that.model.get("__internal_UI_businessMetadataName"), key: key, val: val }) +
'</td>';
+ var td = '<td class="custom-col-1" data-key="' + key +
'">' + key + ' (' + _.escape(val.typeName) + ')</td><td
class="custom-col-0">:</td><td class="custom-col-1" data-id="value">' +
that.getAttrElement({ businessMetadata:
that.model.get("__internal_UI_businessMetadataName"), key: key, val: val }) +
'</td>';
td += '<td class="custom-col-2 btn-group">' +
'<button class="btn btn-default btn-sm" data-key="' +
key + '" data-id="deleteItem">' +
diff --git
a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
index 2fb835e26..e695c4559 100644
--- a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
+++ b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js
@@ -389,7 +389,7 @@ define(['require',
trs = "";
_.each(this.model.attributes, function(val, key) {
if (key !== "__internal_UI_businessMetadataName" && key !==
"isNew") {
- var td = '<td class="custom-col-1" data-key=' + key + '>'
+ key + ' (' + _.escape(val.typeName) + ')</td><td
class="custom-col-0">:</td><td class="custom-col-1" data-id="value">' +
that.getAttrElement({ businessMetadata:
that.model.get("__internal_UI_businessMetadataName"), key: key, val: val }) +
'</td>';
+ var td = '<td class="custom-col-1" data-key="' + key +
'">' + key + ' (' + _.escape(val.typeName) + ')</td><td
class="custom-col-0">:</td><td class="custom-col-1" data-id="value">' +
that.getAttrElement({ businessMetadata:
that.model.get("__internal_UI_businessMetadataName"), key: key, val: val }) +
'</td>';
td += '<td class="custom-col-2 btn-group">' +
'<button class="btn btn-default btn-sm" data-key="' +
key + '" data-id="deleteItem">' +
