HDPDGI-76:Baban:Hide tabs other than details is not Table (cherry picked from commit d54a598)
Project: http://git-wip-us.apache.org/repos/asf/incubator-atlas/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/844c79a6 Tree: http://git-wip-us.apache.org/repos/asf/incubator-atlas/tree/844c79a6 Diff: http://git-wip-us.apache.org/repos/asf/incubator-atlas/diff/844c79a6 Branch: refs/heads/branch-0.5-incubating Commit: 844c79a644d7050162deaa1e30a2bf27480f6ee5 Parents: 88d2095 Author: Vishal Kadam <[email protected]> Authored: Mon Jun 15 21:02:19 2015 -0700 Committer: Venkatesh Seetharam <[email protected]> Committed: Tue Jun 16 17:33:24 2015 -0700 ---------------------------------------------------------------------- dashboard/v2/bower.json | 1 - dashboard/v2/public/modules/details/detailsController.js | 8 ++++---- dashboard/v2/public/modules/details/views/details.html | 6 +++--- 3 files changed, 7 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/844c79a6/dashboard/v2/bower.json ---------------------------------------------------------------------- diff --git a/dashboard/v2/bower.json b/dashboard/v2/bower.json index 711be46..581f682 100755 --- a/dashboard/v2/bower.json +++ b/dashboard/v2/bower.json @@ -1,4 +1,3 @@ - { "name": "dgc-metadata", "description": "Apache Atlas", http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/844c79a6/dashboard/v2/public/modules/details/detailsController.js ---------------------------------------------------------------------- diff --git a/dashboard/v2/public/modules/details/detailsController.js b/dashboard/v2/public/modules/details/detailsController.js index b5550a3..0e96d42 100644 --- a/dashboard/v2/public/modules/details/detailsController.js +++ b/dashboard/v2/public/modules/details/detailsController.js @@ -22,19 +22,19 @@ angular.module('dgc.details').controller('DetailsController', ['$window', '$scop function($window, $scope, $stateParams, DetailsResource) { $scope.tableName = false; + $scope.isTable = false; + DetailsResource.get({ id: $stateParams.id }, function(data) { $scope.details = data; + $scope.schemas = data; $scope.tableName = data.values.name; + $scope.isTable = data.typeName === 'Table'; }); $scope.isString = angular.isString; - $scope.schemas = DetailsResource.get({ - id: $stateParams.id - }); - $scope.onActivate = function tabActivate(tabname) { $scope.$broadcast('render-lineage', { type: tabname, http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/844c79a6/dashboard/v2/public/modules/details/views/details.html ---------------------------------------------------------------------- diff --git a/dashboard/v2/public/modules/details/views/details.html b/dashboard/v2/public/modules/details/views/details.html index 5e3cae5..19f0ce0 100644 --- a/dashboard/v2/public/modules/details/views/details.html +++ b/dashboard/v2/public/modules/details/views/details.html @@ -41,9 +41,9 @@ </tbody> </table> </tab> - <tab data-heading="Schema"><ng-include src="'/modules/details/views/schema.html'"/></tab> - <tab data-heading="Output" data-disable="!tableName" data-select="onActivate('outputs')"><ng-include data-table-type="outputs" src="'/modules/lineage/views/lineage.html'"/></tab> - <tab data-heading="Input" data-disable="!tableName" data-select="onActivate('inputs')"><ng-include data-table-type="inputs" src="'/modules/lineage/views/lineage.html'"/></tab> + <tab data-heading="Schema" data-ng-if="isTable"><ng-include src="'/modules/details/views/schema.html'"/></tab> + <tab data-heading="Output" data-ng-if="isTable" data-disable="!tableName" data-select="onActivate('outputs')"><ng-include data-table-type="outputs" src="'/modules/lineage/views/lineage.html'"/></tab> + <tab data-heading="Input" data-ng-if="isTable" data-disable="!tableName" data-select="onActivate('inputs')"><ng-include data-table-type="inputs" src="'/modules/lineage/views/lineage.html'"/></tab> </tabset> </div> </div>
