Repository: incubator-atlas Updated Branches: refs/heads/master 6c06fd0a7 -> 6ec94374a
ATLAS-388 UI : On creating Tag, the page to be reset for creating new Tag (Anilg via shwethags) Project: http://git-wip-us.apache.org/repos/asf/incubator-atlas/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/6ec94374 Tree: http://git-wip-us.apache.org/repos/asf/incubator-atlas/tree/6ec94374 Diff: http://git-wip-us.apache.org/repos/asf/incubator-atlas/diff/6ec94374 Branch: refs/heads/master Commit: 6ec94374a907a033b36a8af297be054b79ee8fa4 Parents: 6c06fd0 Author: Shwetha GS <[email protected]> Authored: Mon Feb 1 11:53:55 2016 +0530 Committer: Shwetha GS <[email protected]> Committed: Mon Feb 1 11:53:55 2016 +0530 ---------------------------------------------------------------------- dashboard/public/css/common.css | 4 ++++ .../public/modules/notification/views/notifications.html | 2 +- .../modules/tags/definition/definitionTagsController.js | 11 +++++++++-- dashboard/public/modules/tags/definition/views/add.html | 4 ++-- release-log.txt | 1 + 5 files changed, 17 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/6ec94374/dashboard/public/css/common.css ---------------------------------------------------------------------- diff --git a/dashboard/public/css/common.css b/dashboard/public/css/common.css index 853c664..54857c7 100644 --- a/dashboard/public/css/common.css +++ b/dashboard/public/css/common.css @@ -375,4 +375,8 @@ Tags on Home Page design .graph{ overflow: hidden!important; +} +.notifier{ + margin-right: 15px; + margin-left: -15px; } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/6ec94374/dashboard/public/modules/notification/views/notifications.html ---------------------------------------------------------------------- diff --git a/dashboard/public/modules/notification/views/notifications.html b/dashboard/public/modules/notification/views/notifications.html index dcc02c5..3010384 100644 --- a/dashboard/public/modules/notification/views/notifications.html +++ b/dashboard/public/modules/notification/views/notifications.html @@ -17,7 +17,7 @@ --> <div class="container" data-ng-controller="NotificationController"> - <alert data-ng-repeat="notification in getNotifications()" data-type="{{notification.type}}" data-close="close(notification)"> + <alert data-ng-repeat="notification in getNotifications()" data-type="{{notification.type}}" data-close="close(notification)" class="notifier"> {{notification.message}} </alert> </div> http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/6ec94374/dashboard/public/modules/tags/definition/definitionTagsController.js ---------------------------------------------------------------------- diff --git a/dashboard/public/modules/tags/definition/definitionTagsController.js b/dashboard/public/modules/tags/definition/definitionTagsController.js index ba5f877..39b256b 100755 --- a/dashboard/public/modules/tags/definition/definitionTagsController.js +++ b/dashboard/public/modules/tags/definition/definitionTagsController.js @@ -27,9 +27,9 @@ angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$ attributeDefinitions: [] }; $scope.typesList = NavigationResource.get(); - + $scope.newtagModel = angular.copy($scope.tagModel); $scope.addAttribute = function AddAttribute() { - $scope.tagModel.attributeDefinitions.push(AttributeDefinition.getModel()); + $scope.tagModel.attributeDefinitions.push(AttributeDefinition.getModel()); }; $scope.removeAttribute = function(index) { @@ -40,6 +40,11 @@ angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$ $scope.categoryInst = Categories[$scope.category].clearTags(); }; + $scope.reset = function(){ + $scope.tagModel = angular.copy($scope.newtagModel); + $scope.selectedParent = undefined; + }; + $scope.refreshTags = function(){ var httpDefaultCache = $cacheFactory.get('$http'); httpDefaultCache.remove('/api/atlas/types?type=TRAIT'); @@ -61,6 +66,8 @@ angular.module('dgc.tags.definition').controller('DefinitionTagsController', ['$ NotificationService.info('"' + $scope.tagModel.typeName + '" has been created', false); var httpDefaultCache = $cacheFactory.get('$http'); httpDefaultCache.remove('/api/atlas/types?type=TRAIT'); + $scope.typesList = NavigationResource.get(); + $scope.reset(); }).catch(function TagCreateFailed(error) { NotificationService.error(error.data.error, false); }).finally(function() { http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/6ec94374/dashboard/public/modules/tags/definition/views/add.html ---------------------------------------------------------------------- diff --git a/dashboard/public/modules/tags/definition/views/add.html b/dashboard/public/modules/tags/definition/views/add.html index 1e53f07..3fe1ba0 100755 --- a/dashboard/public/modules/tags/definition/views/add.html +++ b/dashboard/public/modules/tags/definition/views/add.html @@ -32,7 +32,7 @@ </select> </div> </div> - <div class="form-group" data-ng-class="{'has-error': tagForm.typeName.$invalid && tagForm.typeName.$dirty}"> + <div class="form-group" > <label for="typeName" class="col-sm-2 control-label">Tag Name</label> <div class="col-sm-10"> @@ -53,7 +53,7 @@ </div> </div> <ng-form name="attributeForm"> - <div class="form-group" data-ng-class="{'has-error': attributeForm.name.$invalid && attributeForm.name.$dirty}" + <div class="form-group" data-ng-repeat-start="attribute in tagModel.attributeDefinitions"> <label for="attributeId_{{$index}}" class="col-sm-2 control-label">Attribute name</label> http://git-wip-us.apache.org/repos/asf/incubator-atlas/blob/6ec94374/release-log.txt ---------------------------------------------------------------------- diff --git a/release-log.txt b/release-log.txt index 0fa222f..93e2866 100644 --- a/release-log.txt +++ b/release-log.txt @@ -7,6 +7,7 @@ ATLAS-409 Atlas will not import avro tables with schema read from a file (dosset ATLAS-379 Create sqoop and falcon metadata addons (venkatnrangan,bvellanki,sowmyaramesh via shwethags) ALL CHANGES: +ATLAS-388 UI : On creating Tag, the page to be reset for creating new Tag (Anilg via shwethags) ATLAS-199 webapp build fails (grunt + tests) (sanjayp via shwethags) ATLAS-415 Hive import fails when importing a table that is already imported without StorageDescriptor information (yhemanth via shwethags) ATLAS-450 quick_start fails on cygwin (dkantor via shwethags)
