Copilot commented on code in PR #1313:
URL: https://github.com/apache/auron/pull/1313#discussion_r2357637925
##########
native-engine/datafusion-ext-functions/src/spark_sha2.rs:
##########
@@ -93,3 +93,92 @@ fn hex_encode<T: AsRef<[u8]>>(data: T) -> String {
}
s
}
+
+#[cfg(test)]
+mod tests {
+ use std::error::Error;
+
+ use datafusion::{
+ common::ScalarValue, error::Result as DataFusionResult,
physical_plan::ColumnarValue,
+ };
+
+ use crate::spark_sha2::{spark_sha224, spark_sha256, spark_sha384,
spark_sha512};
+
+ /// Helper function to run a test for a given hash function and scalar
+ /// input.
+ fn run_scalar_test(
+ // Accepts any function that matches the signature of your spark_sha*
functions.
Review Comment:
[nitpick] The comment uses informal language ('your spark_sha* functions').
Consider using more formal documentation style: 'Accepts any function that
matches the signature of the spark_sha* functions.'
```suggestion
// Accepts any function that matches the signature of the spark_sha*
functions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
