richox commented on code in PR #1317:
URL: https://github.com/apache/auron/pull/1317#discussion_r2362677260
##########
native-engine/datafusion-ext-commons/src/arrow/cast.rs:
##########
@@ -51,6 +51,11 @@ pub fn cast_impl(
return try_cast_string_array_to_date(array);
}
+ // use std parse to cast string to float
+ (&DataType::Utf8, to_dt) if to_dt.is_floating() => {
Review Comment:
should we also support string -> int casting?
##########
native-engine/datafusion-ext-commons/src/arrow/cast.rs:
##########
@@ -51,6 +51,11 @@ pub fn cast_impl(
return try_cast_string_array_to_date(array);
}
+ // use std parse to cast string to float
+ (&DataType::Utf8, to_dt) if to_dt.is_floating() => {
+ return try_cast_string_array_to_float(array, to_dt);
Review Comment:
i suggest adding a config to manually enable/disable this feature, since it
has different behavior in different hive/spark versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
