ShreyeshArangath commented on code in PR #1330:
URL: https://github.com/apache/auron/pull/1330#discussion_r2370791816
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/common/AuronSQLConf.scala:
##########
@@ -0,0 +1,153 @@
+package org.apache.spark.sql.auron.common
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.internal.SQLConf.buildConf
+
+object AuronSQLConf extends SQLConf {
+
+ val UDF_UDF_JSON_ENABLED =
+ buildConf("spark.auron.udf.UDFJson.enabled")
+ .doc("Enable native implemented get_json_object/json_tuple. May
introduce inconsistency in special case (especially with illegal json inputs).")
+ .booleanConf
+ .createWithDefault(true)
+
+ val UDF_BRICK_HOUSE_ENABLED =
+ buildConf("spark.auron.udf.brickhouse.enabled")
+ .doc("Enable some native-implemented brickhouse UDFs.")
+ .booleanConf
+ .createWithDefault(true)
+
+ val DECIMAL_ARITH_OP_ENABLED =
+ buildConf("spark.auron.decimal.arithOp.enabled")
+ .doc("")
+ .booleanConf
+ .createWithDefault(false)
+
+ val ENABLED_SCAN =
+ buildConf("spark.auron.enable.scan")
+ .doc("Enable/disable auron engine.")
Review Comment:
The doc here does not seem complete
```suggestion
.doc("Enable/disable auron engine for scans.")
```
?
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/common/AuronSQLConf.scala:
##########
@@ -0,0 +1,153 @@
+package org.apache.spark.sql.auron.common
+
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.internal.SQLConf.buildConf
+
+object AuronSQLConf extends SQLConf {
+
+ val UDF_UDF_JSON_ENABLED =
+ buildConf("spark.auron.udf.UDFJson.enabled")
+ .doc("Enable native implemented get_json_object/json_tuple. May
introduce inconsistency in special case (especially with illegal json inputs).")
+ .booleanConf
+ .createWithDefault(true)
+
+ val UDF_BRICK_HOUSE_ENABLED =
+ buildConf("spark.auron.udf.brickhouse.enabled")
+ .doc("Enable some native-implemented brickhouse UDFs.")
+ .booleanConf
+ .createWithDefault(true)
+
+ val DECIMAL_ARITH_OP_ENABLED =
+ buildConf("spark.auron.decimal.arithOp.enabled")
+ .doc("")
Review Comment:
Should we add doc here? This particularly stands out as its disabled by
default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
