guixiaowen commented on code in PR #1373:
URL: https://github.com/apache/auron/pull/1373#discussion_r2394423129
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -138,12 +138,21 @@ object AuronConverters extends Logging {
getBooleanConf("spark.auron.enable.scan.parquet", defaultValue = true)
def enableScanOrc: Boolean =
getBooleanConf("spark.auron.enable.scan.orc", defaultValue = true)
+ def enableShuffleExechange: Boolean =
+ getBooleanConf("spark.auron.enable.shuffleExchange", defaultValue = true)
private val extConvertProviders =
ServiceLoader.load(classOf[AuronConvertProvider]).asScala
def extConvertSupported(exec: SparkPlan): Boolean = {
extConvertProviders.exists(_.isSupported(exec))
}
+ def enableExchange(): Boolean = {
+ val shuffleMangerName =
SQLConf.get.getConfString(config.SHUFFLE_MANAGER.key)
+ enableShuffleExechange && !shuffleMangerName.isEmpty &&
(shuffleMangerName.contains(
+ "AuronShuffleManager") || shuffleMangerName.contains(
+ "AuronUniffleShuffleManager") ||
shuffleMangerName.contains("AuronCelebornShuffleManager"))
Review Comment:
> ```scala
> AuronCelebornShuffleManager
> ```
@ShreyeshArangath she Yes, I think you’re right — this part is indeed
hard-coded. The main reason is that Celeborn or Uniffle may not be introduced
directly here, so the class AuronCelebornShuffleManager may not necessarily be
available to reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
