guixiaowen commented on code in PR #1452:
URL: https://github.com/apache/auron/pull/1452#discussion_r2447769336
##########
auron-build.sh:
##########
@@ -298,7 +298,7 @@ mkdir -p "$(dirname "$BUILD_INFO_FILE")"
JAVA_VERSION=$(java -version 2>&1 | head -n 1 | awk '{print $3}' | tr -d '"')
PROJECT_VERSION=$(xmllint --xpath
"/*[local-name()='project']/*[local-name()='properties']/*[local-name()='project.version']/text()"
pom.xml)
-RUST_VERSION=$(rustc --version | awk '{print $2}')
+RUST_VERSION=$(command -v rustc >/dev/null 2>&1 && rustc --version | awk
'{print $2}' || echo "")
Review Comment:
> i suggest to use `cargo --version` here because we use cargo for
compiling. we can stop building if cargo is not found.
@richox Thank you very much for reviewing the code. I’ve made the changes —
thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
