slfan1989 commented on code in PR #1585:
URL: https://github.com/apache/auron/pull/1585#discussion_r2484241212
##########
spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/auron/AuronFunctionSuite.scala:
##########
@@ -319,4 +319,21 @@ class AuronFunctionSuite
val row = df.collect().head
assert(row.isNullAt(0) && row.isNullAt(1) && row.isNullAt(2))
}
+
+ test("test function greatest") {
+ withTable("t1") {
+ sql(
+ "create table t1 using parquet as select 1" +
Review Comment:
https://spark.apache.org/docs/latest/api/sql/index.html#greatest
```
greatest(expr, ...) - Returns the greatest value of all parameters, skipping
null values.
```
We should design a unit test that includes NULL, for example:
```
SELECT greatest(10, 9, 2, 4, 3, null);
```
##########
native-engine/auron-serde/proto/auron.proto:
##########
@@ -267,6 +267,8 @@ enum ScalarFunction {
Factorial=65;
Hex=66;
Power=67;
+
Review Comment:
Avoid Blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
