slfan1989 commented on code in PR #1563:
URL: https://github.com/apache/auron/pull/1563#discussion_r2485323250
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -309,7 +309,7 @@ jobs:
run: |
mkdir -p /tmp/rss/data && mkdir -p /tmp/rss/logs && \
cd celeborn-bin-${{
steps.get-dependency-version.outputs.celebornversion }} && \
- bash -c "echo -e
'CELEBORN_MASTER_MEMORY=4g\nCELEBORN_WORKER_MEMORY=4g\nCELEBORN_WORKER_OFFHEAP_MEMORY=8g\nCELEBORN_LOG_DIR=/tmp/rss/logs'
> ./conf/celeborn-env.sh" && \
+ bash -c "echo -e
'CELEBORN_MASTER_MEMORY=4g\nCELEBORN_WORKER_MEMORY=4g\nCELEBORN_WORKER_OFFHEAP_MEMORY=8g\nCELEBORN_LOG_DIR=/tmp/rss/logs\nCELEBORN_MASTER_JAVA_OPTS=\"-Xmx2g
-Xms1g\"\nCELEBORN_WORKER_JAVA_OPTS=\"-Xmx3g -Xms1g\"' >
./conf/celeborn-env.sh" && \
Review Comment:
I've also run into OOMs in Celeborn’s CI multiple times. Adding this
configuration is reasonable, but it’s not directly related to the native
implementation in this PR. I suggest opening a separate PR to adjust the JVM
parameters and keeping this PR focused on the feature implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
