ShreyeshArangath commented on code in PR #1444:
URL: https://github.com/apache/auron/pull/1444#discussion_r2487529368
##########
spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/auron/BuildinfoInSparkUISuite.scala:
##########
@@ -17,12 +17,18 @@
package org.apache.spark.sql.auron
import org.apache.spark.sql.execution.ui.AuronSQLAppStatusListener
+import org.apache.spark.util.Utils
class BuildinfoInSparkUISuite
extends org.apache.spark.sql.QueryTest
with BuildInfoAuronSQLSuite
with AuronSQLTestHelper {
+ override protected def beforeAll(): Unit = {
+ super.beforeAll()
+ val eventLogDir = Utils.createTempDir("/tmp/spark-events")
Review Comment:
Taking a look again, I think the order here needs to be flipped. The
directory is required for the spark context creation, otherwise the tests will
fail.
```suggestion
val eventLogDir = Utils.createTempDir("/tmp/spark-events")
super.beforeAll()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
