merrily01 commented on code in PR #1599: URL: https://github.com/apache/auron/pull/1599#discussion_r2489293007
########## dev/docker-build/centos7/Dockerfile: ########## @@ -44,3 +44,15 @@ RUN /rustup-init -y --default-toolchain nightly-2025-05-09-x86_64-unknown-linux- # install java RUN yum install -y java-1.8.0-openjdk java-1.8.0-openjdk-devel RUN echo 'export JAVA_HOME="/usr/lib/jvm/java-1.8.0-openjdk"' >> ~/.bashrc + +# install maven Review Comment: Thanks for bringing this up. @yew1eb Actually, we previously had Maven pre-installed in the image (see [this change](https://github.com/apache/auron/pull/1213/files#diff-6c1f73b68e36d1754a80968e9e087397d90ee302d9e57bf930dac57c0c02c174L45) ), but since the introduction of `build/mvn`, that dependency became redundant. Pre-installing Maven in the Docker image may speed up builds, but it will also make the base image heavier and blur the boundary between build and runtime environments. If needed, i think users could create their own image (e.g., centos:with-maven) for build purposes instead of adding Maven back into the base image ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
