cxzl25 commented on code in PR #1657:
URL: https://github.com/apache/auron/pull/1657#discussion_r2567606557


##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -467,9 +471,25 @@ object AuronConverters extends Logging {
     relation.fileFormat match {
       case p if p.getClass.getName.endsWith("ParquetFileFormat") =>
         assert(enableScanParquet)
+        if (!enableScanParquetTimestamp) {
+          assert(
+            !exec.requiredSchema.exists(e => existTimestampType(e.dataType)),
+            s"Parquet scan with timestamp type is not supported for table: 
${tableIdentifier

Review Comment:
   
   
   ```bash
   spark-sql (default)> set spark.auron.enable.scan.parquet.timestamp=false;
   spark.auron.enable.scan.parquet.timestamp    false
   Time taken: 0.054 seconds, Fetched 1 row(s)
   spark-sql (default)> select * from t3_parquet ;
   25/11/27 16:34:36 WARN AuronConverters: Falling back exec: 
FileSourceScanExec: assertion failed: Parquet scan with timestamp type is not 
supported for table: `spark_catalog`.`default`.`t3_parquet`. Set 
spark.auron.enable.scan.parquet.timestamp=true to enable timestamp support or 
remove timestamp columns from the query.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to