yew1eb commented on code in PR #1726:
URL: https://github.com/apache/auron/pull/1726#discussion_r2609172632
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/Shims.scala:
##########
@@ -123,6 +123,8 @@ abstract class Shims {
def createNativeLocalLimitExec(limit: Long, child: SparkPlan):
NativeLocalLimitBase
+ def createNativeCollectLimitExec(limit: Int, child: SparkPlan):
NativeCollectLimitBase
Review Comment:
> Do we also need to consider the offset syntax introduced in 3.4?
>
> [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query
expression
Yes, I plan to open a separate issue to support LIMIT with OFFSET.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
