Copilot commented on code in PR #1733:
URL: https://github.com/apache/auron/pull/1733#discussion_r2612870862
##########
pom.xml:
##########
@@ -270,6 +270,57 @@
</dependency>
</dependencies>
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
+
<url>https://maven-central-asia.storage-download.googleapis.com/maven2/</url>
+ </repository>
+
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
+ <name>Maven Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
+
<url>https://maven-central-asia.storage-download.googleapis.com/maven2/</url>
+ </pluginRepository>
+
+ <pluginRepository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
Review Comment:
The pluginRepository definition is missing the 'name' element, which is
present in the corresponding repository definition at line 294. For consistency
and better readability, consider adding a name element such as 'Maven
Repository'.
```suggestion
<id>central</id>
<name>Maven Repository</name>
```
##########
pom.xml:
##########
@@ -270,6 +270,57 @@
</dependency>
</dependencies>
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
+
<url>https://maven-central-asia.storage-download.googleapis.com/maven2/</url>
+ </repository>
+
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
+ <name>Maven Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
Review Comment:
The repository ID 'gcs-maven-central-mirror' is duplicated between the
repositories section (line 281) and the pluginRepositories section. Maven
requires repository IDs to be unique across both sections. Consider using a
different ID for the plugin repository, such as
'gcs-maven-central-mirror-plugins'.
```suggestion
<id>gcs-maven-central-mirror-plugins</id>
<name>GCS Maven Central mirror Asia Pacific (Plugins)</name>
```
##########
pom.xml:
##########
@@ -270,6 +270,57 @@
</dependency>
</dependencies>
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
+
<url>https://maven-central-asia.storage-download.googleapis.com/maven2/</url>
+ </repository>
+
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
+ <name>Maven Repository</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror Asia Pacific</name>
+
<url>https://maven-central-asia.storage-download.googleapis.com/maven2/</url>
+ </pluginRepository>
+
+ <pluginRepository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
Review Comment:
The repository ID 'central' is duplicated between the repositories section
(line 293) and the pluginRepositories section. Maven requires repository IDs to
be unique across both sections. Consider using a different ID for the plugin
repository, such as 'central-plugins'.
```suggestion
<id>central-plugins</id>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
