Copilot commented on code in PR #1756: URL: https://github.com/apache/auron/pull/1756#discussion_r2618261648
########## spark-extension/src/test/resources/log4j2.properties: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +rootLogger.level = info +rootLogger.appenderRef.file.ref = File Review Comment: The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders. ```suggestion rootLogger.appenderRef.file.ref = File rootLogger.appenderRef.console.ref = STDOUT ``` ########## common/src/test/resources/log4j2.properties: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +rootLogger.level = info +rootLogger.appenderRef.file.ref = File Review Comment: The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders. ```suggestion rootLogger.appenderRef.file.ref = File rootLogger.appenderRef.console.ref = STDOUT ``` ########## auron-core/src/test/resources/log4j2.properties: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +rootLogger.level = info +rootLogger.appenderRef.file.ref = File Review Comment: The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders. ```suggestion rootLogger.appenderRef.file.ref = File rootLogger.appenderRef.console.ref = STDOUT ``` ########## spark-extension-shims-spark/src/test/resources/log4j2.properties: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +rootLogger.level = info +rootLogger.appenderRef.file.ref = File Review Comment: The console appender (STDOUT) is configured but never referenced in the rootLogger. Only the File appender is referenced, which means console output will be completely suppressed. To achieve the stated goal of reducing console noise to WARN level while still maintaining console output, add a console appender reference. The rootLogger configuration should include both appenders. ```suggestion rootLogger.appenderRef.file.ref = File rootLogger.appenderRef.stdout.ref = STDOUT ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
