xumingming opened a new issue, #1809: URL: https://github.com/apache/auron/issues/1809
I was reading the semi join implementation and find that the field name: `JoinerParams.probe_is_join_side` is hard to understand its meaning: https://github.com/apache/auron/blob/d357cbc100f01374059c4deaa6856af763164e4c/native-engine/datafusion-ext-plans/src/joins/bhj/semi_join.rs#L60-L64 `join_side` is NOT an adjective, it is a noun, which can be LEFT or RIGHT https://github.com/apache/auron/blob/d357cbc100f01374059c4deaa6856af763164e4c/native-engine/auron-serde/proto/auron.proto#L678-L681 After some digging I think what `probe_is_join_side` want to say is: whether the probe side is the same as the outer side of the join. e.g. For a left join, if the probe side is on the left, then probe_is_join_side is true, otherwise false. BTW: For a left join, left side is the outer side, right side is the inner side. So I suggest to rename `probe_is_join_side` to `is_probe_on_outer_side` and add some comments to make it more easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
