xumingming commented on PR #1793: URL: https://github.com/apache/auron/pull/1793#issuecomment-3703811716
The failed issues are all LeftAnti join related tests which all involve NULLs in the test data. I believe the reason is the following: there are two different kinds of LeftAnti in Spark: 'NOT IN' and 'NOT EXISTS'. Before this PR, Auron's implementation of semi_join.rs implemented 'NOT EXISTS', the standard LeftAnti. It produces incorrect results for the NOT IN queries, like the query you mentioned in #1792 . In this PR, you changed the implementation from 'NOT EXISTS' to 'NOT IN'(actually not a fully implemented 'NOT IN'), so the 'NOT EXISTS'(standard LeftAnti) related tests which involves NULLs failed. I think we should revert this PR and have a better we to handle both NOT IN and NOT EXISTS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
