ShreyeshArangath commented on code in PR #1838:
URL: https://github.com/apache/auron/pull/1838#discussion_r2661408568
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -420,3 +420,12 @@ jobs:
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || ''
}}
path: |
/tmp/rss/logs/*
+
+ - name: Clean up injected JARs to keep Spark bin cache pure
+ if: steps.cache-spark-bin.outputs.cache-hit != 'true'
+ run: |
+ cd spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}/jars/
+ rm -f auron-*${{ inputs.sparkver }}_${{ inputs.scalaver }}*.jar
+ rm -f celeborn-client-spark-*_${{ inputs.scalaver }}-*.jar
Review Comment:
Any uniffle related cleanup?
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -420,3 +420,12 @@ jobs:
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || ''
}}
path: |
/tmp/rss/logs/*
+
+ - name: Clean up injected JARs to keep Spark bin cache pure
Review Comment:
nit:
```suggestion
- name: Clean up injected JARs from Spark bin cache
```
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -420,3 +420,12 @@ jobs:
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || ''
}}
path: |
/tmp/rss/logs/*
+
+ - name: Clean up injected JARs to keep Spark bin cache pure
+ if: steps.cache-spark-bin.outputs.cache-hit != 'true'
+ run: |
+ cd spark-bin-${{ inputs.sparkver }}_${{ inputs.scalaver }}/jars/
+ rm -f auron-*${{ inputs.sparkver }}_${{ inputs.scalaver }}*.jar
+ rm -f celeborn-client-spark-*_${{ inputs.scalaver }}-*.jar
+ rm -f rss-client-spark*.jar
Review Comment:
What is this `rss-client-spark-*` jar, i could not find info on it in the
[issue](https://github.com/apache/auron/issues/1837)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
