richox commented on code in PR #1886:
URL: https://github.com/apache/auron/pull/1886#discussion_r2684717272
##########
native-engine/datafusion-ext-plans/src/orc_exec.rs:
##########
@@ -414,3 +430,698 @@ impl OrcFileMetrics {
Self { bytes_scanned }
}
}
+
+fn convert_predicate_to_orc(
+ predicate: Option<PhysicalExprRef>,
+ file_schema: &SchemaRef,
+) -> Option<Predicate> {
+ let predicate = predicate?;
+ convert_expr_to_orc(&predicate, file_schema)
+}
+
+/// Recursively collect all AND sub-conditions and flatten nested AND
+/// structures.
+fn collect_and_predicates(
+ expr: &Arc<dyn datafusion::physical_expr::PhysicalExpr>,
+ schema: &SchemaRef,
+ predicates: &mut Vec<Predicate>,
+) {
+ if let Some(binary) = expr.as_any().downcast_ref::<BinaryExpr>() {
Review Comment:
we have `SCAndExpr`/`SCOrExpr` for short-circuiting binary logic operators,
could you also add a match arm for these exprs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
