Copilot commented on code in PR #1876:
URL: https://github.com/apache/auron/pull/1876#discussion_r2690517906
##########
spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala:
##########
@@ -1037,6 +1038,24 @@ class ShimsImpl extends Shims with Logging {
override def getAdaptiveInputPlan(exec: AdaptiveSparkPlanExec): SparkPlan = {
exec.inputPlan
}
+
+ @sparkver(" 3.2 / 3.3 / 3.4 / 3.5")
+ override def getIsSkewJoinFromSHJ(exec: ShuffledHashJoinExec): Boolean =
exec.isSkewJoin
+
+ @sparkver("3.0 / 3.1")
+ override def getIsSkewJoinFromSHJ(exec: ShuffledHashJoinExec): Boolean =
false
+
+ @sparkver("3.1 / 3.2 / 3.3 / 3.4 / 3.5")
+ override def getShuffleOrigin(exec: ShuffleExchangeExec): Option[Any] =
Some(exec.shuffleOrigin)
+
+ @sparkver("3.0")
+ override def getShuffleOrigin(exec: ShuffleExchangeExec): Option[Any] = None
+
+ @sparkver("3.1 / 3.2 / 3.3 / 3.4 / 3.5")
+ def isNullAwareAntiJoin(exec: BroadcastHashJoinExec): Boolean =
exec.isNullAwareAntiJoin
+
+ @sparkver("3.0")
+ def isNullAwareAntiJoin(exec: BroadcastHashJoinExec): Boolean = false
Review Comment:
The `isNullAwareAntiJoin` method implementations are missing the `override`
keyword. This method is declared as abstract in the `Shims` class (line 270 in
Shims.scala), so the implementations should include the `override` keyword for
consistency with other methods in this class and to clearly indicate that these
methods are implementing the abstract method.
##########
spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala:
##########
@@ -1037,6 +1038,24 @@ class ShimsImpl extends Shims with Logging {
override def getAdaptiveInputPlan(exec: AdaptiveSparkPlanExec): SparkPlan = {
exec.inputPlan
}
+
+ @sparkver(" 3.2 / 3.3 / 3.4 / 3.5")
Review Comment:
The `@sparkver` annotation has an extra leading space: `" 3.2 / 3.3 / 3.4 /
3.5"` should be `"3.2 / 3.3 / 3.4 / 3.5"` (without the leading space) to match
the pattern used in other version annotations in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
