Copilot commented on code in PR #1908:
URL: https://github.com/apache/auron/pull/1908#discussion_r2704345563
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -286,13 +255,14 @@ jobs:
}}${{ inputs.celebornver && format('-{0}', inputs.celebornver) ||
''
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || ''
}}
- - name: Download TPC-DS Validator JAR
+ - name: Download auron maven artifacts
uses: actions/download-artifact@v7
with:
name: >
- tpcds-validator-${{ inputs.sparkver }}_${{ inputs.scalaver
}}-jdk-${{ inputs.javaver
- }}${{ inputs.celebornver && format('-{0}', inputs.celebornver) ||
''
+ auron-artifacts-${{ inputs.sparkver }}_${{ inputs.scalaver
}}-jdk-${{ inputs.javaver
Review Comment:
Missing closing braces in the GitHub Actions expression. The artifact name
on line 262 ends with `inputs.javaver` but is missing the closing `}}` to
properly close the expression. This should be `inputs.javaver}}` to match the
pattern used in other artifact names.
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -223,10 +184,18 @@ jobs:
}}${{ inputs.unifflever && format('-{0}', inputs.unifflever) || ''
}}
path: target/auron-${{ inputs.sparkver }}_${{ inputs.scalaver
}}-pre-*.jar
overwrite: true
+ - name: Upload auron maven artifacts (Spark ${{ inputs.sparkver }},
Scala ${{ inputs.scalaver }}, JDK ${{ inputs.javaver }})
+ uses: actions/upload-artifact@v4
Review Comment:
There's a version mismatch in the upload-artifact action. Line 188 uses
'actions/upload-artifact@v4', but line 179 and other places in the file use
'@v6'. This inconsistency could lead to compatibility issues. Consider updating
line 188 to use '@v6' to match the rest of the workflow.
```suggestion
uses: actions/upload-artifact@v6
```
##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -159,8 +120,8 @@ jobs:
clippy
- name: Cargo clippy
+ # First eliminate unwrap; then enable -D warnings to enforce all
default lints.
Review Comment:
The comment style change from inline comment to proper YAML comment is good,
but this specific comment text might be better moved to the PR description or
code documentation rather than appearing in the workflow file itself, since
workflow files are typically kept more focused on configuration.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
