cxzl25 commented on code in PR #1964:
URL: https://github.com/apache/auron/pull/1964#discussion_r2762690968


##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronSparkSessionExtension.scala:
##########
@@ -68,7 +63,7 @@ case class AuronColumnarOverrides(sparkSession: SparkSession) 
extends ColumnarRu
   override def preColumnarTransitions: Rule[SparkPlan] = {
     new Rule[SparkPlan] {
       override def apply(sparkPlan: SparkPlan): SparkPlan = {
-        if (!sparkPlan.conf.getConf(auronEnabledKey)) {
+        if (!SparkAuronConfiguration.AURON_ENABLED.get()) {

Review Comment:
   This modification will cause the session setting `set 
spark.auron.enable=true/false` to not take effect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to