Copilot commented on code in PR #1990:
URL: https://github.com/apache/auron/pull/1990#discussion_r2778986877
##########
pom.xml:
##########
@@ -836,6 +836,48 @@
</properties>
</profile>
+ <profile>
+ <id>spark-4.0</id>
+ <properties>
+ <shimName>spark-4.0</shimName>
+ <scalaTestVersion>3.2.9</scalaTestVersion>
+ <sparkVersion>4.0.2</sparkVersion>
+ <shortSparkVersion>4.0</shortSparkVersion>
+ <nettyVersion>4.1.111.Final</nettyVersion>
Review Comment:
PR title/description reference Spark 4.0.1 compatibility, but the new Spark
4.0 Maven profile builds against Spark 4.0.2. Please either switch
`sparkVersion` to 4.0.1 (if that is the compatibility target) or update the PR
metadata/docs to match 4.0.2 so expectations are clear.
##########
dev/auron-it/pom.xml:
##########
@@ -331,6 +331,45 @@
</properties>
</profile>
+ <profile>
+ <id>spark-4.0</id>
+ <properties>
+ <shimName>spark-4.0</shimName>
+ <sparkVersion>4.0.2</sparkVersion>
+ </properties>
Review Comment:
This integration-test Maven profile also pins Spark 4.0 to 4.0.2 while the
PR is framed as Spark 4.0.1 compatibility. Please align the `sparkVersion` here
with the intended target version (or update the PR metadata/docs accordingly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
