Copilot commented on code in PR #2002:
URL: https://github.com/apache/auron/pull/2002#discussion_r2797156470
##########
rust-toolchain.toml:
##########
@@ -16,5 +16,5 @@
# under the License.
[toolchain]
-channel = "nightly-2025-05-09"
+channel = "nightly-2025-12-15"
components = ["rust-src", "cargo", "rustfmt", "clippy"]
Review Comment:
The PR description says this change only updates `rust-toolchain.toml`, but
this PR also includes multiple code edits across `native-engine/*` (let-chains
refactors, `std::slice::from_ref` changes, `xxh_rotl64` implementation change,
etc.). Please update the PR description/rationale to accurately reflect these
additional changes (and the actual upgrade window; 2025-05-09 → 2025-12-15 is
~220 days, not 45).
##########
native-engine/datafusion-ext-functions/src/spark_get_json_object.rs:
##########
@@ -305,15 +305,15 @@ impl HiveGetJsonObjectEvaluator {
json_str: &str,
) -> std::result::Result<Option<String>, HiveGetJsonObjectError> {
// first try parsing with sonic-rs and fail-backing to serde-json
Review Comment:
Typo in comment: "fail-backing" should be "falling back" (or "falling back
to serde-json").
```suggestion
// first try parsing with sonic-rs and falling back to serde-json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
