ShreyeshArangath commented on code in PR #1938: URL: https://github.com/apache/auron/pull/1938#discussion_r2809720589
########## native-engine/datafusion-ext-exprs/src/lib.rs: ########## @@ -22,6 +22,7 @@ pub mod cast; pub mod get_indexed_field; pub mod get_map_value; pub mod named_struct; +pub mod randn; Review Comment: Thoughts on calling this `spark_randn` instead? Flink's randn implementation from what I'm seeing is different from that of spark, and adding the `spark_` prefix will make it similar to what we have with other Spark functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
