slfan1989 commented on code in PR #2016:
URL: https://github.com/apache/auron/pull/2016#discussion_r2849298565
##########
dev/reformat:
##########
@@ -48,15 +48,15 @@ else
cargo fmt --all -q --
fi
-# Check or format all code, including third-party code, with spark-3.5
+# Check or format all code, including third-party code, with spark-3.4
sparkver=spark-3.5
for celebornver in celeborn-0.5 celeborn-0.6
do
- run_maven -P"${sparkver}" -Pceleborn,"${celebornver}" -Puniffle,uniffle-0.10
-Ppaimon,paimon-1.2 -Pflink,flink-1.18 -Piceberg,iceberg-1.9
+ run_maven -P"${sparkver}" -P"${celebornver}" -Puniffle-0.10 -Ppaimon-1.2
-Pflink-1.18 -Piceberg -DicebergEnabled=true -DicebergVersion=1.10.1
done
-sparkvers=(spark-3.0 spark-3.1 spark-3.2 spark-3.3 spark-3.4)
+sparkvers=(spark-3.0 spark-3.1 spark-3.2 spark-3.3 spark-3.5)
Review Comment:
Thank you for taking the time to look into this issue. From my perspective,
this change indeed shouldn’t have appeared in #2016. I’ve submitted #2018 to
address it—when you have a moment, could you please take a look? Thanks very
much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
