Copilot commented on code in PR #2018:
URL: https://github.com/apache/auron/pull/2018#discussion_r2867421253
##########
dev/reformat:
##########
@@ -48,16 +90,32 @@ else
cargo fmt --all -q --
fi
+# Run spotless with a consistent JDK/version to avoid formatting drift.
+run_spotless scala-2.12 spark-3.5
+run_spotless scala-2.13 spark-4.0
+
# Check or format all code, including third-party code, with spark-3.5
+set_java_home 8
sparkver=spark-3.5
for celebornver in celeborn-0.5 celeborn-0.6
do
- run_maven -P"${sparkver}" -Pceleborn,"${celebornver}" -Puniffle,uniffle-0.10
-Ppaimon,paimon-1.2 -Pflink,flink-1.18 -Piceberg,iceberg-1.9
+ run_maven -P"${sparkver}" -Pceleborn,"${celebornver}" -Puniffle,uniffle-0.10
-Ppaimon,paimon-1.2 -Pflink-1.18 -Piceberg-1.9
Review Comment:
`run_spotless` only runs for `scala-2.12/spark-3.5` and
`scala-2.13/spark-4.0` and does not activate the third-party module profiles
(celeborn/uniffle/paimon/flink/iceberg). Since Spotless was removed from
`run_maven`, formatting problems inside those third-party modules are no longer
enforced by `./dev/reformat --check` (and may be silently auto-applied during
`compile` due to the lifecycle-bound Spotless execution). Consider running
`run_spotless` with the same third-party profiles used later in the script, or
reintroducing `spotless:check` for those third-party runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
