weiqingy commented on code in PR #2063: URL: https://github.com/apache/auron/pull/2063#discussion_r2879740679
########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowBooleanColumnVector.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.vector.BitVector; +import org.apache.flink.table.data.columnar.vector.BooleanColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link BooleanColumnVector} backed by an Arrow {@link BitVector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + */ +public final class ArrowBooleanColumnVector implements BooleanColumnVector { + + private BitVector vector; + + /** + * Creates a new wrapper around the given Arrow {@link BitVector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowBooleanColumnVector(BitVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public boolean getBoolean(int i) { + return vector.get(i) != 0; + } + + /** + * Replaces the underlying Arrow vector. Used during reader reset to point at a new batch + * without allocating a new wrapper. + * + * @param vector the new Arrow vector, must not be null + */ + void setVector(BitVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } Review Comment: Correct observation — FlinkArrowReader.reset() currently recreates wrappers rather than calling setVector(). The methods were added intentionally for a future optimization: in a streaming pipeline processing many batches with the same schema, reusing wrapper instances via setVector() avoids per-batch allocations. This is a minor cost (one method per wrapper class) that keeps the optimization path available. Happy to remove if reviewers prefer the leaner approach. ########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/vectors/ArrowBooleanColumnVector.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.vectors; + +import org.apache.arrow.vector.BitVector; +import org.apache.flink.table.data.columnar.vector.BooleanColumnVector; +import org.apache.flink.util.Preconditions; + +/** + * A Flink {@link BooleanColumnVector} backed by an Arrow {@link BitVector}. + * + * <p>This wrapper delegates all reads to the underlying Arrow vector, providing zero-copy access + * to Arrow data from Flink's columnar batch execution engine. + */ +public final class ArrowBooleanColumnVector implements BooleanColumnVector { + + private BitVector vector; + + /** + * Creates a new wrapper around the given Arrow {@link BitVector}. + * + * @param vector the Arrow vector to wrap, must not be null + */ + public ArrowBooleanColumnVector(BitVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } + + /** {@inheritDoc} */ + @Override + public boolean isNullAt(int i) { + return vector.isNull(i); + } + + /** {@inheritDoc} */ + @Override + public boolean getBoolean(int i) { + return vector.get(i) != 0; + } + + /** + * Replaces the underlying Arrow vector. Used during reader reset to point at a new batch + * without allocating a new wrapper. + * + * @param vector the new Arrow vector, must not be null + */ + void setVector(BitVector vector) { + this.vector = Preconditions.checkNotNull(vector); + } Review Comment: Correct observation — FlinkArrowReader.reset() currently recreates wrappers rather than calling setVector(). The methods were added intentionally for a future optimization: in a streaming pipeline processing many batches with the same schema, reusing wrapper instances via setVector() avoids per-batch allocations. This is a minor cost (one method per wrapper class) that keeps the optimization path available. Happy to remove if reviewers prefer the leaner approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
