Flyangz opened a new pull request, #2370:
URL: https://github.com/apache/auron/pull/2370
# Which issue does this PR close?
Closes #2369
# Rationale for this change
Fix some ORC predicate pushdown with OR losing data.
# What changes are included in this PR?
- Made OR pushdown all-or-nothing: collect_or_predicates now returns bool,
and if any disjunct fails to convert, the whole OR is not pushed down
(convert_expr_to_orc returns None). Convertible AND conjuncts
around the OR still push down safely.
- Added unit tests covering: OR with an unconvertible disjunct, OR whose
disjunct is a fully-unconvertible AND, and an unconvertible OR nested in an AND
where the sibling conjunct still pushes down.
# Are there any user-facing changes?
no
# How was this patch tested?
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
